Skip to content

feat: Improve download function #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kroese merged 1 commit into from
Jul 21, 2026
Merged

feat: Improve download function #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 9 additions & 33 deletions src/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ downloadFile() {
local expected="${4:-0}"
local connections="${5:-1}"
local dest="$STORAGE/$base"
local msg total size
local msg

if [ -z "$name" ]; then
msg="Downloading image"
Expand All @@ -19,38 +19,13 @@ downloadFile() {
info "Downloading $name..."
fi

if downloadToFile \
"$url" \
"$dest" \
"$msg" \
"$expected" \
"$connections" \
"Y"; then
return 0
fi

local rc=$?
(( rc != 0 )) && return "$rc"

if ! total=$(stat -c%s -- "$dest"); then
error "Failed to determine downloaded file size: $dest"
return 1
fi

size=$(formatBytes "$total") || return 1

if (( total < 100000 )); then

error "Invalid image file: is only $size ?"

if ! rm -f -- "$dest" "$dest.aria2"; then
warn "failed to remove invalid download \"$dest\"!"
fi

return 1
fi

return 0
downloadToFile \
"$url" \
"$dest" \
"$msg" \
"$expected" \
"$connections" \
"Y"
}

bootFile() {
Expand Down Expand Up @@ -207,6 +182,7 @@ downloadImage() {
"$connections" \
"5" \
"${name:-$base}" \
"$SIZE" \
"$URL" \
"$base" \
"$name" \
Expand Down