Use correct workflow name for static analysis#285
Merged
greg0ire merged 2 commits intodoctrine:0.5.xfrom Mar 15, 2026
Merged
Conversation
greg0ire
approved these changes
Mar 15, 2026
SenseException
commented
Mar 15, 2026
Comment on lines
+15
to
+20
| - | ||
| message: '#Only booleans are allowed in a ternary operator condition, string given\.#' | ||
| path: lib/Span/SpanProcessor.php | ||
| - | ||
| message: '#Only booleans are allowed in an if condition, string given\.#' | ||
| path: lib/Span/SpanProcessor.php |
Member
Author
There was a problem hiding this comment.
I'm ignoring these for now, because I don't want to increase the scope of the PR. The class has no tests and don't want to do the changes for phpstan when those can break the functionality or BC.
greg0ire
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#284 (comment) showed the issue that wasn't visible during the PR. Hopefully this PR will start the workflows.