Conversation
Add DBThreadSafeLock for explicit backend selection and keep the public API source-compatible while defaulting to Synchronization.Mutex on supported OS versions with fallback to pthread_rwlock_t elsewhere. Also preserve nested read compatibility for the default Mutex-backed path and document the backend semantics and availability. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Increase the nested read regression test timeout from 1 to 3 seconds to reduce watchOS simulator flakiness in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rewrite the nested read regression test to assert the same-thread nested read behavior directly instead of relying on DispatchQueue scheduling and semaphore timeouts, which proved flaky on simulator CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DBThreadSafeLockfor explicit backend selection inDBThreadSafeContainerand@ThreadSafeSynchronization.Mutexon supported OS versions and fall back topthread_rwlock_telsewhere without breaking existing initializer call sitesTesting
swift testswift build -Xswiftc -target -Xswiftc arm64-apple-macosx10.15git diff --check