Allow for URL to be passed into the NewCoreRPCClient #1
Open
danielwhelansb wants to merge 2 commits intodogeorg:mainfrom
Open
Allow for URL to be passed into the NewCoreRPCClient #1danielwhelansb wants to merge 2 commits intodogeorg:mainfrom
danielwhelansb wants to merge 2 commits intodogeorg:mainfrom
Conversation
raffecat
reviewed
Oct 30, 2025
Contributor
raffecat
left a comment
raffecat
left a comment
There was a problem hiding this comment.
I'd rather always pass a URL than doing parsing gymnastics (the one other user of the lib can update its call.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to keep this backwards compatible, but allow for a URL to be passed in so that we can use HTTPS if needed.