fix: use DEFAULT_AMT const for fallbacks and fix README sync#23
Merged
Conversation
The hardcoded `2` in the CSS var fallback should reference the DEFAULT_AMT constant to stay consistent if the default ever changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The sync script used `package/dist/...` as marker names but README had `dist/...` markers, so syncing was silently a no-op. Fix by accepting an optional third arg for the actual file path, keeping the marker name matching what's in README. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Moves the sync-readme workflow from push-to-main to pull_request. It auto-commits the synced README to the PR branch, or fails CI if it cannot push (e.g., from a fork). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dogmar
changed the title
Contributor
|
🎉 This PR is included in version 0.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2in the tw-plugin's CSS var fallback with theDEFAULT_AMTconstant fromvariants.tsscripts/sync-readme.shmarker mismatch (package/dist/...vsdist/...) that caused syncing to silently no-op2instead of stale1.5)Test plan
vp run sync-readmeproduces no diff on a clean build🤖 Generated with Claude Code