Merged
Conversation
Report for RSPE01_01 (f8d01da - 1150c32)📈 Matched code: 29.11% (+0.49%, +17172 bytes) ✅ 52 new matches
...and 22 more new matches 📈 9 improvements in unmatched items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr (mostly) matches the rest of NWC24. The only nonmatching function is
NWC24CommitMsgInternaldue to a small regswap. All code was matched with help of Ghidra, Permuter, and AI.NWC24InitBase64Tablewas borrowed from wii-ipl. I followed the formatting guidelines in contributing.md to the best of my ability. The biggest thing wrong with my code at the moment are the strings. I do plan on making updates to this pr to get the strings to match.