Skip to content

Improve accuracy on the mwerks sdk #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyblocker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve accuracy on the mwerks sdk #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ def MatchingFor(*versions):
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common/ansi_files.c"),
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common/abort_exit.c"),
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common/errno.c"),
Object(NonMatching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common_Embedded/ansi_fp.c"),
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common_Embedded/ansi_fp.c"),
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common_Embedded/uart_console_io.c"),
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/MSL_Common/buffer_io.c"),
Object(Matching, "PowerPC_EABI_Support/Msl/MSL_C/PPC_EABI/critical_regions.ppc_eabi.c"),
Expand Down Expand Up @@ -623,7 +623,7 @@ def MatchingFor(*versions):
Object(Matching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/msghndlr.c"),
Object(NonMatching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/support.c"),
Object(Matching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/mutex_TRK.c"),
Object(NonMatching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/notify.c"),
Object(Matching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/notify.c"),
Object(Matching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Processor/ppc/Generic/flush_cache.c"),
Object(Matching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/mem_TRK.c"),
Object(Matching, "TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Processor/ppc/Generic/targimpl.c"),
Expand Down
5 changes: 5 additions & 0 deletions src/PowerPC_EABI_Support/Msl/MSL_C/MSL_Common_Embedded/ansi_fp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ void __num2dec(const decform* f, f64 x, decimal* d)
int var_r6_2;
const f64* var_r5;

// fixes float ordering issue
(void)0.0;
(void)1.0;
(void)4503601774854144.0;

digits = f->digits;
if (digits > 16) {
digits = 16;
Expand Down
9 changes: 3 additions & 6 deletions src/TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/notify.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,21 @@

inline DSError TRKDoNotifyStopped_Inline(TRKBuffer* msg, MessageCommandID cmd)
{
DSError err;

if (msg->position >= 0x880) {
err = DS_MessageBufferOverflow;
return DS_MessageBufferOverflow;
} else {
msg->data[msg->position++] = cmd;
msg->length += 1;
err = 0;
return DS_NoError;
}
return err;
}

DSError TRKDoNotifyStopped(MessageCommandID cmd)
{
DSError err;
int bufIdx;
int reqIdx;
TRKBuffer* msg;
int bufIdx;

err = TRKGetFreeBuffer(&bufIdx, &msg);
if (err == DS_NoError) {
Expand Down
12 changes: 6 additions & 6 deletions src/TRK_MINNOW_DOLPHIN/debugger/embedded/MetroTRK/Portable/support.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
DSError TRKSuppAccessFile(u32 file_handle, u8* data, size_t* count,
DSIOResult* io_result, BOOL need_reply, BOOL read)
{
BOOL exit;
u32 done;
BOOL exit;
DSError error;
TRKBuffer* replyBuffer;
int replyBufferId;
TRKBuffer* buffer;
TRKBuffer* replyBuffer;
u32 length;
int bufferId;
u16 replyLength;
Expand Down Expand Up @@ -56,8 +56,8 @@ DSError TRKSuppAccessFile(u32 file_handle, u8* data, size_t* count,
replyLength = 0;
replyIOResult = DS_IONoError;

error = TRKRequestSend(buffer, &replyBufferId, read ? 5 : 5, 3,
!(read && file_handle == 0));
error = (0, TRKRequestSend(buffer, &replyBufferId, read ? 5 : 5,
3, !(read && file_handle == 0)));
if (error == DS_NoError) {
replyBuffer = (TRKBuffer*)TRKGetBuffer(replyBufferId);
TRKSetBufferPosition(replyBuffer, 2);
Expand All @@ -73,8 +73,8 @@ DSError TRKSuppAccessFile(u32 file_handle, u8* data, size_t* count,
if (read && error == DS_NoError) {
if (replyBuffer->length != replyLength + 5) {
replyLength = replyBuffer->length - 5;
if (replyIOResult == DS_IONoError)
replyIOResult = DS_IOError;
if (replyIOResult == 0)
replyIOResult = 1;
}

if (replyLength <= length)
Expand Down