Skip to content

Work on MarioDraw.cpp#87

Open
TheAzack9 wants to merge 1 commit intodoldecomp:mainfrom
TheAzack9:az-MarioDraw2
Open

Work on MarioDraw.cpp#87
TheAzack9 wants to merge 1 commit intodoldecomp:mainfrom
TheAzack9:az-MarioDraw2

Conversation

@TheAzack9
Copy link
Contributor

@TheAzack9 TheAzack9 commented Feb 27, 2026

This is more fuzzy than i wished for, but i struggled with MarioDraw lmao, so much data...

@decomp-dev
Copy link

decomp-dev bot commented Feb 27, 2026

Report for GMSJ01 (7e32ff1 - ca8b0b7)

📉 Matched code: 27.02% (-0.01%, -484 bytes)
📉 Matched data: 29.43% (-0.11%, -676 bytes)

✅ 26 new matches
Unit Item Bytes Before After
mario/Player/MarioDraw TMario::changeHand(int) +1024 0.00% 100.00%
mario/Player/MarioDraw TMario::entryModels(JDrama::TGraphics*) +308 0.00% 100.00%
mario/Player/MarioDraw TMario::setPositions() +164 0.00% 100.00%
mario/Player/MarioDraw TMario::drawSpecial(JDrama::TGraphics*) +108 0.00% 100.00%
mario/Player/MarioDraw TMario::loadAnmTexPattern(J3DAnmTexPattern**, char*, J3DModelData*) +100 0.00% 100.00%
mario/Player/MarioDraw TMario::setDivHelm() +88 0.00% 100.00%
mario/Player/MarioDraw TMario::isLast1AnimeFrame() +80 0.00% 100.00%
mario/Player/MarioDraw TMario::takeOffGlass() +76 0.00% 100.00%
mario/Player/MarioDraw TMario::wearGlass() +76 0.00% 100.00%
mario/Player/MarioDraw TMario::loadBas(void**, const char*) +72 0.00% 100.00%
mario/Player/MarioDraw TMario::getTrampleCt() +72 0.00% 100.00%
mario/Player/MarioDraw TMario::isWearingHelm() +48 0.00% 100.00%
mario/Player/MarioDraw TMario::isWearingCap() +48 0.00% 100.00%
mario/Player/MarioDraw TMario::getWallAngle() const +48 0.00% 100.00%
mario/Player/MarioDraw TMario::isUpperPumpingStyle() const +36 0.00% 100.00%
mario/Player/MarioDraw TMario::isAnimeLoopOrStop() +36 0.00% 100.00%
mario/Player/MarioDraw TMario::getTakingMtx() +28 0.00% 100.00%
mario/Player/MarioDraw TMario::getCenterAnmMtx() +28 0.00% 100.00%
mario/Player/MarioDraw TMarioAnimeData::isPumpOK() const +28 0.00% 100.00%
mario/Player/MarioDraw TMario::getCurrentFrame(int) +24 0.00% 100.00%
mario/Player/MarioDraw TMario::getTakenMtx() +16 0.00% 100.00%
mario/Player/MarioDraw TMario::getPumpFrame() const +16 0.00% 100.00%
mario/Player/MarioDraw TMario::getRootAnmMtx() +16 0.00% 100.00%
mario/Player/MarioDraw TMario::getMotionFrameCtrl() +12 0.00% 100.00%
mario/Player/MarioDraw TNozzleBase::getGunAngle() +8 0.00% 100.00%
mario/Player/MarioDraw .ctors +4 0.00% 100.00%
🥀 9 broken matches
Unit Item Bytes Before After
mario/System/EventWatcher TSpcTypedBinary<TEventWatcher>::initUserBuiltin() -341 100.00% 81.32%
mario/System/EventWatcher evSetSystemFlag(TSpcTypedInterp<TEventWatcher>*, unsigned long) -13 100.00% 97.56%
mario/System/EventWatcher evAppearShine(TSpcTypedInterp<TEventWatcher>*, unsigned long) -12 100.00% 97.83%
mario/System/MarDirectorSetup2 .rodata -12 100.00% 97.66%
mario/Player/MarioCollision .rodata -11 100.00% 84.21%
mario/Map/MapWireManager .rodata -11 100.00% 73.33%
mario/Map/Shimmer .rodata -11 100.00% 85.19%
mario/Player/MarioBlend M3UModelMario::updateOut() -5 100.00% 94.44%
mario/Player/MarioBlend M3UModelMario::changeMtxCalcSIAnmBQAnmTransform(int, int, unsigned short) -5 100.00% 96.30%
📈 25 improvements in unmatched items
Unit Item Bytes Before After
mario/Player/MarioDraw .data +4557 0.00% 99.25%
mario/Player/MarioDraw .rodata +3071 0.00% 94.81%
mario/Player/MarioDraw TMario::initModel() +2207 0.00% 55.42%
mario/Player/MarioDraw TMario::calcAnim(unsigned long, JDrama::TGraphics*) +1575 0.00% 95.40%
mario/Player/MarioDraw TMario::addCallBack(JDrama::TGraphics*) +875 0.00% 96.05%
mario/Player/MarioDraw .sdata2 +796 4.30% 96.45%
mario/Player/MarioDraw __sinit_MarioDraw_cpp +712 0.00% 93.19%
mario/Player/MarioDraw TMario::addDamageFog(JDrama::TGraphics*) +668 0.00% 87.43%
mario/Player/MarioDraw MarioHeadCtrl(J3DNode*, int) +547 0.00% 48.07%
mario/Player/MarioDraw TMario::setAnimation(int, float) +536 0.00% 58.01%
mario/Player/MarioDraw MarioWaistCtrl(J3DNode*, int) +416 0.00% 66.24%
mario/Player/MarioDraw TMario::addUpper() +391 0.00% 89.91%
mario/Player/MarioDraw TMario::drawLogic() +363 0.00% 89.22%
mario/Player/MarioDraw TMario::boxDrawPrepare(float(*)[4]) +356 0.00% 70.08%
mario/Player/MarioDraw TMario::calcView(JDrama::TGraphics*) +292 0.00% 91.25%
mario/Player/MarioDraw TMario::initMirrorModel() +272 0.00% 95.77%
mario/Player/MarioDraw MarioFootPosLCtrl(J3DNode*, int) +252 0.00% 81.01%
mario/Player/MarioDraw MarioFootPosRCtrl(J3DNode*, int) +252 0.00% 81.01%
mario/Player/MarioDraw TMario::addDirty() +232 0.00% 80.56%
mario/Player/MarioDraw MarioFootDirLCtrl(J3DNode*, int) +196 0.00% 29.88%
mario/Player/MarioDraw MarioFootDirRCtrl(J3DNode*, int) +196 0.00% 29.88%
mario/Player/MarioDraw .bss +178 0.00% 96.77%
mario/Player/MarioDraw TMario::setUpperDamageRun() +147 0.00% 97.37%
mario/Player/MarioDraw TMario::setReverseAnimation(int, float) +135 0.00% 72.34%
mario/Player/MarioDraw TMario::finalDrawInitialize() +112 0.00% 53.85%
📉 33 regressions in unmatched items
Unit Item Bytes Before After
mario/System/MarDirectorSetup2 TMarDirector::setup2() -111 85.01% 77.38%
mario/Enemy/hamukuri THamuKuriSaveLoadParams::THamuKuriSaveLoadParams(const char*) -107 96.05% 80.79%
mario/Player/MarioCollision TMario::decHP(int) -90 84.38% 49.23%
mario/Player/MarioCollision TMario::incHP(int) -44 85.71% 70.00%
mario/System/EventWatcher evSetTransScale(TSpcTypedInterp<TEventWatcher>*, unsigned long) -32 71.98% 70.05%
mario/Enemy/hamukuri TFireHamuKuriManager::initSetEnemies() -32 68.32% 60.40%
mario/System/EventWatcher evKillWoodBox(TSpcTypedInterp<TEventWatcher>*, unsigned long) -29 83.43% 79.29%
mario/System/EventWatcher evRefreshWoodBox(TSpcTypedInterp<TEventWatcher>*, unsigned long) -29 83.43% 79.29%
mario/System/EventWatcher evCheckWoodBox(TSpcTypedInterp<TEventWatcher>*, unsigned long) -29 88.89% 84.80%
mario/Player/MarioInit TMario::TMario() -15 77.93% 77.85%
mario/System/EventWatcher .rodata -12 97.96% 97.39%
mario/System/EventWatcher evStartAppearJetBalloon(TSpcTypedInterp<TEventWatcher>*, unsigned long) -12 79.47% 77.48%
mario/System/EventWatcher evSetEventID(TSpcTypedInterp<TEventWatcher>*, unsigned long) -12 74.00% 72.00%
mario/System/EventWatcher evSetDead4LiveActor(TSpcTypedInterp<TEventWatcher>*, unsigned long) -12 83.45% 81.29%
mario/System/EventWatcher evSetHide4LiveActor(TSpcTypedInterp<TEventWatcher>*, unsigned long) -12 83.45% 81.29%
mario/System/EventWatcher evSetTalkMsgID(TSpcTypedInterp<TEventWatcher>*, unsigned long) -12 65.62% 63.28%
mario/Enemy/hamukuri THamuKuri::setMActorAndKeeper() -12 82.46% 77.19%
mario/System/EventWatcher evSetCollision(TSpcTypedInterp<TEventWatcher>*, unsigned long) -11 76.58% 74.68%
mario/System/EventWatcher evIsInsideFastCube(TSpcTypedInterp<TEventWatcher>*, unsigned long) -11 97.73% 96.02%
mario/System/EventWatcher evInsertTimer(TSpcTypedInterp<TEventWatcher>*, unsigned long) -11 77.30% 75.18%
mario/System/EventWatcher evSetNextStage(TSpcTypedInterp<TEventWatcher>*, unsigned long) -11 66.92% 64.62%
mario/System/EventWatcher evIsOnLiveActorFlag(TSpcTypedInterp<TEventWatcher>*, unsigned long) -11 75.32% 73.38%
mario/System/EventWatcher evPushNerve4LiveActor(TSpcTypedInterp<TEventWatcher>*, unsigned long) -11 80.54% 78.52%
mario/Enemy/hamukuri .rodata -11 99.37% 98.76%
mario/Player/MarioCollision TMario::loserExec() -9 94.05% 91.11%
mario/System/EventWatcher evAppearShineForWoodBox(TSpcTypedInterp<TEventWatcher>*, unsigned long) -8 98.90% 96.70%
mario/System/EventWatcher evRaiseBuilding(TSpcTypedInterp<TEventWatcher>*, unsigned long) -8 68.00% 66.00%
mario/Enemy/hamukuri TFireHamuKuri::setMActorAndKeeper() -8 75.00% 70.00%
mario/Player/MarioBlend M3UModelMario::updateInMotion() -5 87.36% 86.21%
mario/Player/MarioInit .rodata -5 35.53% 35.47%

...and 3 more regressions in unmatched items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheAzack9