Skip to content

ci: add Codecov test results upload to enable Test Analytics#9

Merged
bcdonadio merged 1 commit into
masterfrom
feature/fix-codecov-test-results-upload
Nov 2, 2025
Merged

ci: add Codecov test results upload to enable Test Analytics#9
bcdonadio merged 1 commit into
masterfrom
feature/fix-codecov-test-results-upload

Conversation

@bcdonadio

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the Codecov test results upload issue by adding the codecov/test-results-action@v1 to the CI workflow. Previously, test results were not being uploaded to Codecov Test Analytics despite JUnit XML files being generated correctly.

Changes Made

  • Added codecov/test-results-action@v1 step in .github/workflows/ci.yml (after line 222) to upload test results to Codecov Test Analytics
  • Fixed codecov/codecov-action@v4 configuration by removing ./junit.xml from the files parameter (line 218), as this action is designed for coverage reports only
  • Maintained existing dorny/test-reporter@v1 integration for GitHub Checks visibility

Root Cause

The workflow was incorrectly passing junit.xml to codecov/codecov-action@v4, which is designed for coverage reports (coverage.xml), not test results. While pytest was generating JUnit XML correctly, no action was uploading these test results to Codecov Test Analytics.

Benefits

This change enables several Codecov Test Analytics features:

  • ✅ Test failure tracking and trend analysis
  • ✅ Flaky test detection
  • ✅ Test performance metrics and historical data
  • ✅ Better visibility into test suite health

Test Results Distribution

After this change, test results will be available in three places:

  1. Codecov Test Analytics (new) - via codecov/test-results-action@v1
  2. GitHub Checks (existing) - via dorny/test-reporter@v1
  3. Coverage Reports (existing) - via codecov/codecov-action@v4

Test Plan

  • Run make check locally - all checks passed
  • Verify workflow YAML syntax is valid
  • Wait for CI to complete successfully
  • Verify test results appear in Codecov Test Analytics dashboard
  • Confirm GitHub Checks still show test results as before
  • Ensure coverage reports continue uploading correctly

References

🤖 Generated with Claude Code

The CI workflow was using codecov/codecov-action@v4 for coverage reporting
but was not uploading test results to Codecov Test Analytics. This change:

- Adds codecov/test-results-action@v1 to upload junit.xml to Test Analytics
- Removes junit.xml from codecov-action files parameter (coverage only)
- Maintains existing dorny/test-reporter for GitHub Checks integration

This enables Codecov Test Analytics features including test failure tracking,
flaky test detection, and test performance metrics.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings November 2, 2025 14:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates coverage and test results uploads to Codecov by using two distinct actions. Previously, both coverage.xml and junit.xml were uploaded together through the codecov-action. Now, coverage is uploaded via codecov/codecov-action and test results are uploaded separately via codecov/test-results-action.

  • Split Codecov uploads into separate steps for coverage and test results
  • Introduced codecov/test-results-action@v1 for JUnit test results
  • Removed junit.xml from the original codecov-action file list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
@codecov

codecov Bot commented Nov 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
@bcdonadio bcdonadio merged commit 2a511d3 into master Nov 2, 2025
20 checks passed
@bcdonadio bcdonadio deleted the feature/fix-codecov-test-results-upload branch November 2, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants