Audio round 2: looping engine audio (racing3d/car3d) + native loop-retune fix#33
Open
doodlewind wants to merge 1 commit into
Open
Audio round 2: looping engine audio (racing3d/car3d) + native loop-retune fix#33doodlewind wants to merge 1 commit into
doodlewind wants to merge 1 commit into
Conversation
…tune fix
Exercises + verifies the loop path (loop/stopLoop -> SND_OP_SET_LOOP) that round 1
built but never used. All EXISTING visual goldens byte-identical (no HUD added).
- racing3d.js / car3d.js: speed-modulated engine loop via SoundBank.loop('engine',
{pitch ~ speed}); retuned only when the quantized pitch changes; stopLoop at rest.
No visual HUD -> RGBA/.dc3d goldens unchanged.
- audio.ts flush(): SET_LOOP now emitted ONLY on a real wire delta (on/off, gain, or
pitch-while-on) — a held throttle at saturated pitch emits nothing; stopLoop emits
exactly one gain==0; idle-from-boot emits nothing. Fixes per-frame ring spam.
- runtime/src/audio.rs: NATIVE loop-retune fix — the re-parameterize branch dropped
c.pitch (a running loop was stuck at its start pitch). Now recomputes the Q16 phase
step from base_freq×pitch WITHOUT resetting phase (retunes, no click).
- dodge.js: one-shot SFX (coin.pickup / collision.impact), no HUD.
- golden.ts: new racing3d/car3d/dodge .snd.json event goldens asserting SET_LOOP-on
(pitch 156->410) + OFF (gain==0) + dodge coin TRIGGER.
Verified: bun run test green (24 golden, same count, all prior visual goldens
byte-identical; loop event goldens prove the path); typecheck clean. Native: racing3d
EBOOT compiles + boots in PPSSPP — pspjs_audio thread scheduled, DAC fed (627x
OutputBlocking/16s under auto-accel), SET_LOOP retune branch runs, no crash, 60fps.
Audible pitch-modulation pending a human listen.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 2 of the audio self-iteration — exercises + verifies the loop path (
loop/stopLoop→SND_OP_SET_LOOP) that round 1 (#30) built but never used. All existing visual goldens stay byte-identical (audio is invisible; no HUD added).What
SoundBank.loop('engine', {pitch ~ speed}), retuned only when the quantized pitch changes,stopLoopat rest. No visual HUD → RGBA/.dc3d goldens unchanged.audio.tsflush():SET_LOOPnow emitted only on a real wire delta (on/off, gain, or pitch-while-on) — held throttle at saturated pitch emits nothing;stopLoopemits exactly onegain==0; idle-from-boot emits nothing. Fixes per-frame ring spam (found in review).runtime/src/audio.rs— native loop-retune fix: round 1's re-parameterize branch droppedc.pitch, so a running loop was stuck at its start pitch (the engine wouldn't modulate). Now recomputes the Q16 phasestepfrombase_freq × pitchwithout resetting phase (retunes, no click).racing3d/car3d/dodge.snd.jsonevent goldens assertingSET_LOOP-on (pitch 156→410), OFF (gain==0), and dodge coinTRIGGER.Verification (re-run by me)
typecheckclean;bun run testgreen — 24 golden (same count), every prior.rgbz/.dc3dbyte-identical (git diff goldens/empty); new event goldens prove the loop path (SET_LOOP-on ×112, pitch 156→410+ OFF; dodgeTRIGGER×1).pspjs_audiothread scheduled,sceAudioSRCChReserve+ 627×OutputBlockingin 16s (DAC fed), theSET_LOOPretune branch runs, no crash, 60 fps.bun run serve/ device).Not auto-merging — ear-check the engine pitch sweep, then I'll merge + continue (round 3: music loops, more games).
🤖 Generated with Claude Code