pro edition - #43
Open
surafel212121 wants to merge 6 commits into
Open
Conversation
…ion.cpp The method Engine::scene() does not exist. The correct public accessor is Engine::getScene(). This fixes the compilation error on line 117 where scenes member is private. Fixes #build-failure
Contributor
|
There are several things in this PR I don't agree with, and others where I didn't understand the reasoning. For example: Is World a second entity/component store alongside Scene / EntityRegistry? Why is InputBinder never fed by Engine input? Do AssetManager::load / loadAsync only set isLoaded = true? What about prefabs? And our .bundle system? Almost none of it is called from Engine, Scene, Input, UISystem, or SceneManager. You need to provide more details, describe what is being created, and, preferably, create smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.