Skip to content

fix(serv): bound shutdown so Ctrl-C exits when SSE/keep-alive conns linger #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitdeshmukh merged 1 commit into from
Apr 29, 2026
Merged

fix(serv): bound shutdown so Ctrl-C exits when SSE/keep-alive conns linger #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions serv/serv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,18 @@ func startHTTP(s1 *HttpService) {
sigint := make(chan os.Signal, 1)
signal.Notify(sigint, os.Interrupt)
<-sigint
s.log.Info("shutdown signal received")

if err := s.srv.Shutdown(context.Background()); err != nil {
s.log.Warn("shutdown signal received")
// Bounded shutdown: don't wait forever on lingering connections
// (e.g. MCP SSE streams or idle keep-alives).
shutdownCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

if err := s.srv.Shutdown(shutdownCtx); err != nil {
s.log.Warnf("graceful shutdown timed out, forcing close: %s", err)
s.srv.Close() //nolint:errcheck
}
close(idleConnsClosed)
}()

s.srv.RegisterOnShutdown(func() {
if s.closeFn != nil {
s.closeFn()
}
Expand All @@ -93,7 +97,8 @@ func startHTTP(s1 *HttpService) {
}
}
s.log.Info("shutdown complete")
})
close(idleConnsClosed)
}()

ver := version
// dep := s.conf.name
Expand Down
Loading