Open
Conversation
Added following sentences CUR HDT MDA MWV ROT
dotMorten
reviewed
Dec 22, 2021
Owner
dotMorten
left a comment
dotMorten
left a comment
There was a problem hiding this comment.
Thank you for this. At first quick glance looks like a solid PR. Do you have a reference to these messages? I'm not sure what these represent - perhaps we can find a better namespace for these.
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;netstandard1.4;netcoreapp2.1;net451;monoandroid50;monoandroid70;xamarinios10;uap10.0.16299</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0;netstandard1.4;netcoreapp2.1;net451;uap10.0.16299</TargetFrameworks> |
| @@ -0,0 +1,197 @@ | |||
| namespace NmeaParser.Nmea.Class | |||
Owner
There was a problem hiding this comment.
The Class namespace is a bit unfortunate and could be confusing
|
I was reviewing the project to see if I wanted to use it and saw this PR. Here is the info on these sentences.
Do you want someone to pick this up and finish it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added following sentences.
CUR
HDT
MDA
MWV
ROT
Added class type