Skip to content

Codex pnpm audit fixes - #153

Merged
dotmh merged 2 commits into
mainfrom
codex-pnpm-audit-fixes
May 17, 2026
Merged

Codex pnpm audit fixes#153
dotmh merged 2 commits into
mainfrom
codex-pnpm-audit-fixes

Conversation

@dotmh

@dotmh dotmh commented May 17, 2026

Copy link
Copy Markdown
Owner

This pull request updates the project's development dependencies to their latest versions and introduces explicit pnpm package overrides to ensure consistent dependency resolution. Additionally, it clarifies and expands the security policy in SECURITY.md to provide clearer guidance for vulnerability reporters.

Dependency updates and package management:

  • Updated several development dependencies in package.json to their latest versions, including @commitlint/cli, @commitlint/config-conventional, @secretlint/secretlint-rule-preset-recommend, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, @vitest/coverage-istanbul, eslint, eslint-plugin-promise, secretlint, vitest, and yaml.
  • Added a pnpm.overrides section to package.json to pin specific versions of key dependencies (ajv@8, brace-expansion@1, fast-uri, flatted, picomatch, postcss, rollup, and vite) for improved build consistency and compatibility.

Security policy improvements:

  • Enhanced the assessment outcome section in SECURITY.md to clarify the process for accepting or rejecting vulnerability reports, including the appeal process and next steps if a report is accepted.
  • Expanded the disclosure policy in SECURITY.md to explicitly request confidentiality, reasonable disclosure timelines, and good faith actions from reporters.

Summary by CodeRabbit

  • Documentation

    • Security documentation enhanced with explicit information on assessment outcomes and appeal procedures.
    • Disclosure policy section reorganized with improved formatting and additional guidance.
  • Chores

    • Development dependencies updated to latest stable, compatible versions across multiple packages.
    • Dependency version management strengthened with explicit version pinning for consistency.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 17, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This PR updates security documentation to clarify assessment outcomes and adds spacing for readability, while also upgrading dev dependency versions and introducing pnpm transitive dependency pinning to ensure consistent builds.

Changes

Maintenance Updates

Layer / File(s) Summary
Security documentation clarification
SECURITY.md
Assessment Outcome section is restructured to explicitly separate accepted and rejected outcomes with appeal guidance, and spacing is adjusted in the disclosure policy section.
Dependency and transitive dependency updates
package.json
Dev dependencies are upgraded to newer versions (commitlint, @secretlint, @typescript-eslint, vitest, eslint, yaml); pnpm.overrides configuration is added to explicitly pin transitive dependencies (ajv, brace-expansion, fast-uri, flatted, picomatch, postcss, rollup, vite).

🎯 2 (Simple) | ⏱️ ~8 minutes

A rabbit hops through the code with care,
Tightening docs and deps everywhere—
Security shines with clearer prose,
And pinned transitive versions compose.
🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Codex pnpm audit fixes' directly relates to the main changes in the PR, which involve updating dev dependencies and adding pnpm package overrides for audit compliance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex-pnpm-audit-fixes

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Around line 26-27: Update release validation by confirming Node.js target and
testing linting/secret workflows: verify the project's Node.js engine/version
(ensure it meets Node.js 22+ if upgrading `@commitlint/cli` to ^21.0.1), run
commitlint CLI with current config (packages "`@commitlint/cli`" and
"`@commitlint/config-conventional`") to observe the new CLI output formatting and
test using the --legacy-output flag where needed, and run secretlint (including
v13 behavior) against the repo to confirm .gitignore is respected and no files
are unintentionally excluded; if issues appear, either pin commitlint to a
Node-compatible version, adjust package.json engines, or update CI scripts to
pass --legacy-output and update secretlint config to explicitly include/exclude
files.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c2e680fa-76f9-4e75-b581-7a273302c87a

📥 Commits

Reviewing files that changed from the base of the PR and between c0625b0 and 459284e.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • SECURITY.md
  • package.json

Comment thread package.json
Comment on lines +26 to +27
"@commitlint/cli": "^21.0.1",
"@commitlint/config-conventional": "^21.0.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the existence of the specified package versions

echo "Checking `@commitlint/cli`@21.0.1..."
npm view `@commitlint/cli`@21.0.1 version 2>/dev/null || echo "❌ Version not found"

echo "Checking `@secretlint/secretlint-rule-preset-recommend`@13.0.2..."
npm view `@secretlint/secretlint-rule-preset-recommend`@13.0.2 version 2>/dev/null || echo "❌ Version not found"

echo "Checking secretlint@13.0.2..."
npm view secretlint@13.0.2 version 2>/dev/null || echo "❌ Version not found"

echo ""
echo "Fetching release notes for major version changes..."
echo "Commitlint v21 changes:"
gh api repos/conventional-changelog/commitlint/releases --jq '.[] | select(.tag_name | startswith("v21")) | {tag: .tag_name, url: .html_url}' | head -5

echo ""
echo "Secretlint v12 and v13 changes:"
gh api repos/secretlint/secretlint/releases --jq '.[] | select(.tag_name | startswith("v12") or startswith("v13")) | {tag: .tag_name, url: .html_url}' | head -10

Repository: dotmh/ts

Length of output: 1216


🌐 Web query:

commitlint v21 release notes changelog breaking changes

💡 Result:

Commitlint v21.0.0 was released on May 8, 2026 [1][2]. This major release includes several breaking changes and internal cleanups [1]. Breaking Changes: - Minimum Node.js version: The minimum supported Node.js version has been increased to v22 [1]. - CLI Output: The CLI now displays input from a new line [1]. A --legacy-output flag has been introduced as a transitional escape hatch to maintain previous behavior, though it is planned for removal in a future major release [1]. Users are advised to migrate their parsers and snapshots to the new format during the v21 lifecycle [1]. Other Notable Changes: - Dependency Cleanup: Significant internal refactoring was performed to leverage Node.js 22 built-ins, resulting in the removal of dependencies such as glob, fast-glob, import-meta-resolve, minimist, and fs-extra [1]. - Dependency Updates: Updated yargs to v18 and widened the cz-commitlint inquirer peer dependency to support versions 9–12 [1]. For a complete list of changes, you can view the full changelog on the official GitHub repository [1].

Citations:


🌐 Web query:

secretlint v13 v12 release notes breaking changes migration guide

💡 Result:

Secretlint v13.0.0 was released on May 4, 2026 [1]. A key change in this version is that secretlint now respects.gitignore files by default [1]. Regarding the transition from v12 to v13, users should consult the official changelog on GitHub for a comprehensive list of changes [1]. While specific, detailed migration guides are often maintained within the repository's documentation or release notes, the primary breaking change noted in recent development cycles for secretlint has been the shift toward security-focused defaults, such as making --maskSecrets the default behavior (implemented in earlier versions) [2]. To migrate or upgrade: 1. Review the full changelog between v12.3.1 and v13.0.0 on GitHub to identify any specific breaking changes affecting your configuration [1]. 2. Test your existing workflows, especially those relying on file inclusion/exclusion, as the new default behavior of respecting.gitignore may change which files are scanned [1]. 3. If you encounter issues with file scanning, you may need to adjust your configuration or CLI arguments to explicitly include or exclude files as necessary. For the most accurate and up-to-date information, always refer to the official GitHub releases page [3].

Citations:


Verify compatibility with Node.js 22 requirement and test for output format/scanning behavior changes.

Major version bumps introduce breaking changes that require testing:

  • @commitlint v21.0.1: Requires Node.js 22 minimum (increased from previous requirement). CLI output format now displays from a new line; --legacy-output flag available for backward compatibility during migration.
  • @secretlint v13.0.2: Now respects .gitignore files by default, potentially changing which files are scanned for secrets.

Verify the project's Node.js target version and test commit message linting and secret detection workflows before merging.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` around lines 26 - 27, Update release validation by confirming
Node.js target and testing linting/secret workflows: verify the project's
Node.js engine/version (ensure it meets Node.js 22+ if upgrading `@commitlint/cli`
to ^21.0.1), run commitlint CLI with current config (packages "`@commitlint/cli`"
and "`@commitlint/config-conventional`") to observe the new CLI output formatting
and test using the --legacy-output flag where needed, and run secretlint
(including v13 behavior) against the repo to confirm .gitignore is respected and
no files are unintentionally excluded; if issues appear, either pin commitlint
to a Node-compatible version, adjust package.json engines, or update CI scripts
to pass --legacy-output and update secretlint config to explicitly
include/exclude files.

@dotmh
dotmh merged commit cafdc8f into main May 17, 2026
6 checks passed
@dotmh
dotmh deleted the codex-pnpm-audit-fixes branch May 17, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant