Skip to content

Adding http log enricher doc and sample code#36852

Merged
wadepickett merged 11 commits intodotnet:mainfrom
mariamgerges:mariamaziz/http-log-enricher-doc
Mar 16, 2026
Merged

Adding http log enricher doc and sample code#36852
wadepickett merged 11 commits intodotnet:mainfrom
mariamgerges:mariamaziz/http-log-enricher-doc

Conversation

@mariamgerges
Copy link
Contributor

@mariamgerges mariamgerges commented Mar 9, 2026

@mariamgerges mariamgerges reopened this Mar 9, 2026
@guardrex
Copy link
Collaborator

Hello @mariamgerges ... Is there an issue for this PR, or where you working with Tom or Wade on getting this content merged?

@mariamgerges
Copy link
Contributor Author

Hello @mariamgerges ... Is there an issue for this PR, or where you working with Tom or Wade on getting this content merged?

hey, no I don't have an issue on github for this PR, I'm working on adding documentation for dotnet extensions features that don't have documentation yet.

@guardrex
Copy link
Collaborator

Awesome! We normally require an issue first, and that gives the team an opportunity to discuss the details of the content before the PR goes up. However, it's no big deal to open the issue after the fact and add a Fixes {ISSUE NUMBER} to the OP of this PR. There are often things like title, physical location, UID to discuss, but that can be done here on the PR.

One important thing to note is that we're trying to place samples in the dedicated samples repo, which keeps this repo lean and easier to fork/clone ...

https://github.com/dotnet/AspNetCore.Docs.Samples

... so you probably should place the sample for this there.

Anyway, you can just take up the discussion here on these points.

I'll ping @tdykstra and @wadepickett to manage this. I'm just a lowly nobody contractor 😆, and they're actually the folks in charge of things around here. Stand-by ... one or both of them will be along shortly to assist.

@mariamgerges
Copy link
Contributor Author

mariamgerges commented Mar 11, 2026

so I added the sample in this PR , should I remove it from here and just add intext code?

Awesome! We normally require an issue first, and that gives the team an opportunity to discuss the details of the content before the PR goes up. However, it's no big deal to open the issue after the fact and add a Fixes {ISSUE NUMBER} to the OP of this PR. There are often things like title, physical location, UID to discuss, but that can be done here on the PR.

One important thing to note is that we're trying to place samples in the dedicated samples repo, which keeps this repo lean and easier to fork/clone ...

https://github.com/dotnet/AspNetCore.Docs.Samples

... so you probably should place the sample for this there.

Anyway, you can just take up the discussion here on these points.

I'll ping @tdykstra and @wadepickett to manage this. I'm just a lowly nobody contractor 😆, and they're actually the folks in charge of things around here. Stand-by ... one or both of them will be along shortly to assist.

@wadepickett
Copy link
Contributor

@mariamgerges, hi! Thanks for the awsome effort. We just worked through a preview release, sorry for the delay.

I will look this over in the morning and see how I can help.

@wadepickett wadepickett requested a review from tdykstra March 16, 2026 19:14
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new title looks good to me.

Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @mariamgerges, thanks so muich. Approved and merging.

@wadepickett wadepickett merged commit 1e4d1ae into dotnet:main Mar 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing IHttpLogEnricher doc

4 participants