Adding http log enricher doc and sample code#36852
Conversation
|
Hello @mariamgerges ... Is there an issue for this PR, or where you working with Tom or Wade on getting this content merged? |
hey, no I don't have an issue on github for this PR, I'm working on adding documentation for dotnet extensions features that don't have documentation yet. |
|
Awesome! We normally require an issue first, and that gives the team an opportunity to discuss the details of the content before the PR goes up. However, it's no big deal to open the issue after the fact and add a One important thing to note is that we're trying to place samples in the dedicated samples repo, which keeps this repo lean and easier to fork/clone ... https://github.com/dotnet/AspNetCore.Docs.Samples ... so you probably should place the sample for this there. Anyway, you can just take up the discussion here on these points. I'll ping @tdykstra and @wadepickett to manage this. I'm just a lowly nobody contractor 😆, and they're actually the folks in charge of things around here. Stand-by ... one or both of them will be along shortly to assist. |
|
so I added the sample in this PR , should I remove it from here and just add intext code?
|
|
@mariamgerges, hi! Thanks for the awsome effort. We just worked through a preview release, sorry for the delay. I will look this over in the morning and see how I can help. |
tdykstra
left a comment
There was a problem hiding this comment.
The new title looks good to me.
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
wadepickett
left a comment
There was a problem hiding this comment.
Fantastic work @mariamgerges, thanks so muich. Approved and merging.
Fixes #36864
Internal previews
Internal previews