Update Library.Template tooling and test runner - #1458
Merged
Conversation
Adds a -NoCoverage switch to dotnet-test-cloud.ps1 for both the MTP and VSTest code paths. Code coverage instrumentation can destabilize a test run, and when it does there is currently no way for a repo to keep running tests on the affected leg without hand-editing this script. Also collect a crash report alongside the crash dump, and restrict the dump to the heap. On Linux the native crash report is often the only way to identify the faulting thread and instruction when a test host dies of an access violation, and a heap dump is considerably smaller than the default full dump while still containing everything needed to analyze managed state. Finally, stop discarding crash dumps that have no TRX attachment copy. The previous filter kept a .dmp only when it appeared under a TRX 'In' directory, so on GitHub Actions -- which does not request a TRX report -- every crash dump was dropped from the uploaded artifacts, making test host crashes impossible to diagnose. The dumps are now de-duplicated by file name instead, which still avoids uploading the same dump twice on Azure Pipelines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add -NoCoverage switch and improve crash diagnostics
Resolved the merge conflict in tools/dotnet-test-cloud.ps1 by preserving the repo's conditional TRX publishing while retaining the incoming crash-dump diagnostics and updated test-runner arguments. Also applied the template's SDK/tooling updates in .devcontainer/Dockerfile, global.json, and tools/Install-DotNetSdk.ps1. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the repo up to date with the latest Library.Template changes so local builds and CI use the same SDK/tooling path and test-runner behavior as the template.
This updates the repo to the template's .NET SDK and installer changes, including the 10.0.400 SDK pin and the more resilient SDK installer logic. It also resolves the merge conflict in the cloud test runner by keeping the repository's existing TRX/reporting behavior while retaining the incoming crash-dump diagnostics and updated MTP arguments.
Validation completed locally: