Skip to content

Re-enable Linux code coverage to reproduce instrumentation AccessViolationException, #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhnaseer wants to merge 18 commits into
base: main
Choose a base branch
from
+22 −10
Open

Re-enable Linux code coverage to reproduce instrumentation AccessViolationException, #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
da6ecb0
Re-enable Linux code coverage to reproduce instrumentation AccessViol…
fhnaseer Aug 13, 2026
fad697e
Revert deterministic MSBuild dispose to reintroduce AccessViolationEx…
fhnaseer Aug 13, 2026
a94be67
Retrigger CI to attempt Linux coverage AccessViolationException repro,
fhnaseer Aug 13, 2026
6493615
Restore deterministic MSBuild dispose to keep PR workflow-only,
fhnaseer Aug 13, 2026
d4862c1
Update code coverage to 18.10.0,
fhnaseer Aug 13, 2026
ef2d24b
Add dnceng public test-tools feed to nuget config,
fhnaseer Aug 13, 2026
92d2c8d
Bump Microsoft.Testing.Extensions.CodeCoverage to 18.11.0-preview.264…
fhnaseer Aug 13, 2026
0dbee3e
Map Microsoft.Testing.Platform packages to test-tools feed,
fhnaseer Aug 13, 2026
c0d136f
Pin Microsoft.Testing.Platform packages to fix NU1603 from coverage p…
fhnaseer Aug 13, 2026
9cae3c8
Bump Microsoft.Testing.Platform to 2.4.0-preview.26411.1 to clear NU1…
fhnaseer Aug 13, 2026
1e1b137
Resolve Microsoft.Testing.Platform packages from test-tools feed,
fhnaseer Aug 13, 2026
c873da2
fix,
fhnaseer Aug 13, 2026
e74ad64
Map all Microsoft.Testing.* packages to the test-tools feed,
fhnaseer Aug 13, 2026
7617a52
fixing feed,
fhnaseer Aug 13, 2026
eb7c732
merge,
fhnaseer Aug 13, 2026
eea7eda
fixing again,
fhnaseer Aug 13, 2026
c041c24
one more try,
fhnaseer Aug 13, 2026
210d371
again,
fhnaseer Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"rollForward": false
},
"dotnet-coverage": {
"version": "18.9.0",
"version": "18.10.0",
"commands": [
"dotnet-coverage"
],
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,7 @@ jobs:
git config --global user.email me@ci.com

Write-Host "🧪 Run tests"
# Code coverage instrumentation is disabled on Linux because the coverage engine's
# shared-memory probe buffers are unmapped while instrumented code is still writing to
# them, crashing the test host with an AccessViolationException.
# The Windows leg still uploads coverage to codecov.io.
$noCoverage = '${{ runner.os }}' -eq 'Linux'
tools/dotnet-test-cloud.ps1 -Configuration ${{ env.BUILDCONFIGURATION }} -Agent ${{ runner.os }} -PublishResults -NoCoverage:$noCoverage
tools/dotnet-test-cloud.ps1 -Configuration ${{ env.BUILDCONFIGURATION }} -Agent ${{ runner.os }} -PublishResults
shell: pwsh
timeout-minutes: 15
- name: 🧪 test x86
Expand Down Expand Up @@ -128,7 +123,6 @@ jobs:
./tools/publish-CodeCov.ps1 -CodeCovToken '${{ secrets.CODECOV_TOKEN }}' -PathToCodeCoverage "${{ runner.temp }}/_artifacts/coverageResults" -Name "${{ runner.os }} Coverage Results" -Flags "${{ runner.os }}"
}
shell: pwsh
if: runner.os != 'Linux'
timeout-minutes: 3

required_status_checks:
Expand Down
6 changes: 4 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
<MicrosoftTestingPlatformVersion>2.3.3</MicrosoftTestingPlatformVersion>
<MicrosoftTestingPlatformVersion>2.4.0-preview.26411.1</MicrosoftTestingPlatformVersion>
<BenchmarkDotNetVersion>0.15.8</BenchmarkDotNetVersion>
<MSBuildPackageVersion>16.11.6</MSBuildPackageVersion>
<!-- LibGit2Sharp Native Binary version - used in both main project and Cake addin -->
Expand Down Expand Up @@ -40,7 +40,9 @@
<PackageVersion Include="Xunit.Combinatorial" Version="2.0.24" />
</ItemGroup>
<ItemGroup Label="Library.Template">
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.9.0" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.11.0-preview.26413.3" />
<PackageVersion Include="Microsoft.Testing.Platform" Version="$(MicrosoftTestingPlatformVersion)" />
<PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="$(MicrosoftTestingPlatformVersion)" />
<PackageVersion Include="Microsoft.Testing.Extensions.CrashDump" Version="$(MicrosoftTestingPlatformVersion)" />
<PackageVersion Include="Microsoft.Testing.Extensions.HangDump" Version="$(MicrosoftTestingPlatformVersion)" />
<PackageVersion Include="Microsoft.Testing.Extensions.Telemetry" Version="$(MicrosoftTestingPlatformVersion)" />
Expand Down
16 changes: 16 additions & 0 deletions nuget.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
<clear />
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
<add key="Consumption" value="https://pkgs.dev.azure.com/andrewarnott/OSS/_packaging/Consumption/nuget/v3/index.json" />
<add key="test-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" />
<add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
</packageSources>
<disabledPackageSources>
<!-- Defend against user or machine level disabling of sources that we list in this file. -->
Expand All @@ -20,5 +22,19 @@
<packageSource key="Consumption">
<package pattern="Nerdbank.GitVersioning.LKG" />
</packageSource>
<packageSource key="test-tools">
<package pattern="Microsoft.Testing.Extensions.CodeCoverage" />
<package pattern="Microsoft.CodeCoverage*" />
<package pattern="dotnet-coverage" />
</packageSource>
<packageSource key="dotnet-tools">
<package pattern="Microsoft.Testing.Platform" />
<package pattern="Microsoft.Testing.Platform.MSBuild" />
<package pattern="Microsoft.Testing.Extensions.CrashDump" />
<package pattern="Microsoft.Testing.Extensions.HangDump" />
<package pattern="Microsoft.Testing.Extensions.Telemetry" />
<package pattern="Microsoft.Testing.Extensions.TrxReport" />
<package pattern="Microsoft.Testing.Extensions.TrxReport.Abstractions" />
</packageSource>
</packageSourceMapping>
</configuration>
Loading