Conversation
ad1f4de to
c412933
Compare
| #region Constants & Scaffolder Definition — ASP.NET Core Identity | ||
|
|
||
| [Fact] | ||
| public void ScaffolderName_IsIdentity_Net11() |
There was a problem hiding this comment.
How useful are all these redundant tests which are only verifying a bunch of consts?
| Assert.True(settings.Overwrite); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
what are any of these actually testing, IdentitySettings just consists of getters and setters, there is no logic in them
| Assert.True(File.Exists(fullPath), $"Template file not found: {relativePath}\nFull path: {fullPath}"); | ||
| } | ||
|
|
||
| private static IdentityModel CreateTestIdentityModel() |
There was a problem hiding this comment.
Same comment here - all the above tests seem to be just testing simple getter/setters of IdentityModel.
| } | ||
| } | ||
|
|
||
| private static string GetActualTemplatesBasePath() |
There was a problem hiding this comment.
I'm wondering if we it would be better more generic bill of materials test like we do in project system, instead of having individual tests for each file or group of files.
|
I am going to update so that the files are actually generated in the different projects after scaffolding and before build, right now it just builds, scaffolds, builds but the files aren't actually added |
fa3c6f1 to
ff30256
Compare
df53972 to
631c2a2
Compare
631c2a2 to
c028c9f
Compare
adds integration tests for AspNet core identity, net 8, net 9, net 10, net 11
fixes Add Asp Net Core Identity net 8 integration tests #3609 fixes Add Asp Net Core Identity net 9 integration tests #3610 fixes Add Asp Net Core Identity net 10 integration tests #3611 fixes Add Asp Net Core Identity net 11 integration tests #3612
adds integration tests for MVC Area, net 8, net 9, net 10, net 11
fixes Add MVC Area net 8 integration tests #3613 fixes Add MVC Area net 9 integration tests #3614 fixes Add MVC Area net 10 integration tests #3615 fixes Add MVC Area net 11 integration tests #3616
adds integration tests for MVC Controller, net 8, net 9, net 10, net 11
fixes Add MVC Controller net 8 integration tests #3617 fixes Add MVC Controller net 9 integration tests #3618 fixes Add MVC Controller net 10 integration tests #3619 fixes Add MVC Controller net 11 integration tests #3620
adds integration tests for MVC Controller Entity Framework with CRUD, net 8, net 9, net 10, net 11
fixes Add MVC Controller with entity framework CRUD net 8 integration tests #3621 fixes Add MVC Controller with entity framework CRUD net 9 integration tests #3622 fixes Add MVC Controller with entity framework CRUD net 10 integration tests #3623 fixes Add MVC Controller with entity framework CRUD net 11 integration tests #3624
adds integration tests for Razor View Empty net 8, net 9, net 10, net 11
fixes Add Razor View Empty net 8 integration tests #3625 fixes Add Razor View Empty net 9 integration tests #3626 fixes Add Razor View Empty net 10 integration tests #3627 fixes Add Razor View Empty net 11 integration tests #3628
adds integration tests for Razor Views net 8, net 9, net 10, net 11
fixes Add Razor Views net 8 integration tests #3629 fixes Add Razor Views net 9 integration tests #3630 fixes Add Razor Views net 10 integration tests #3631 fixes Add Razor Views net 11 integration tests #3632
adds integration tests for Razor Page Empty net 8, net 9, net 10, net 11
fixes Add Razor Page Empty net 8 integration tests #3633 fixes Add Razor Page Empty net 9 integration tests #3634 fixes Add Razor Page Empty net 10 integration tests #3635 fixes Add Razor Page Empty net 11 integration tests #3636
adds integration tests for Razor Page with Entity Framework net 8, net 9, net 10, net 11
fixes Add Razor Page with Entity Framework 8 integration tests #3637 fixes Add Razor Page with Entity Framework 9 integration tests #3638 fixes Add Razor Page with Entity Framework 10 integration tests #3639 fixes Add Razor Page with Entity Framework 11 integration tests #3640