Skip to content

Add more integration tests#3662

Open
haileymck wants to merge 15 commits intomainfrom
dev/hmckelvie/add-more-integration-tests
Open

Add more integration tests#3662
haileymck wants to merge 15 commits intomainfrom
dev/hmckelvie/add-more-integration-tests

Conversation

@haileymck
Copy link
Member

@haileymck haileymck commented Feb 20, 2026

@haileymck haileymck force-pushed the dev/hmckelvie/add-more-integration-tests branch from ad1f4de to c412933 Compare February 20, 2026 17:25
#region Constants & Scaffolder Definition — ASP.NET Core Identity

[Fact]
public void ScaffolderName_IsIdentity_Net11()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How useful are all these redundant tests which are only verifying a bunch of consts?

Assert.True(settings.Overwrite);
}

[Fact]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are any of these actually testing, IdentitySettings just consists of getters and setters, there is no logic in them

Assert.True(File.Exists(fullPath), $"Template file not found: {relativePath}\nFull path: {fullPath}");
}

private static IdentityModel CreateTestIdentityModel()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here - all the above tests seem to be just testing simple getter/setters of IdentityModel.

}
}

private static string GetActualTemplatesBasePath()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we it would be better more generic bill of materials test like we do in project system, instead of having individual tests for each file or group of files.

https://devdiv.visualstudio.com/DevDiv/_git/dotnet-project-system?path=/dotnet-project-system/tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTests/Setup/PackageContentTests.cs

@haileymck
Copy link
Member Author

I am going to update so that the files are actually generated in the different projects after scaffolding and before build, right now it just builds, scaffolds, builds but the files aren't actually added

@haileymck haileymck force-pushed the dev/hmckelvie/add-more-integration-tests branch from fa3c6f1 to ff30256 Compare February 24, 2026 21:46
@haileymck haileymck force-pushed the dev/hmckelvie/add-more-integration-tests branch from df53972 to 631c2a2 Compare February 25, 2026 19:42
@haileymck haileymck force-pushed the dev/hmckelvie/add-more-integration-tests branch from 631c2a2 to c028c9f Compare February 26, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment