Skip to content

Conversation

@lbussell
Copy link
Member

Follow-up to #7002, still working towards #6915.

After this, the plan is to get the release staging to tag itself with the staging container names of the images that it builds and stages.

@lbussell lbussell requested a review from a team as a code owner January 22, 2026 21:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the update-dependencies-internal infrastructure to use stage container names (e.g., "stage-1234567") instead of integer build IDs. This is a follow-up to PR #7002 and works towards implementing issue #6915, which aims to have the release staging pipeline tag builds with release storage account staging container names for better coordination between .NET release pipelines and .NET containers release pipelines.

Changes:

  • Changed parameter and internal storage from integer build IDs to string stage container names throughout the codebase
  • Introduced a new PipelinesService to centralize Azure DevOps build operations
  • Renamed InternalStagingBuilds to InternalStageContainers and updated the storage file from "internal-versions.txt" to "stage-containers.txt"

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/UpdateDependencies.Tests/SyncInternalReleaseTests.cs Updated test data to use stage container strings instead of integer build IDs
tests/UpdateDependencies.Tests/InternalStagingBuildsTests.cs Renamed class references and updated test data types; removed redundant imports
tests/UpdateDependencies.Tests/FromStagingPipelineCommandTests.cs Updated test parameters to use stage container strings and added mock for new PipelinesService
eng/update-dependencies/Sync/InternalStageContainers.cs Renamed from InternalStagingBuilds; changed version mapping from int to string
eng/update-dependencies/Sync/IInternalVersionsService.cs Updated interface to accept stage container strings instead of build IDs
eng/update-dependencies/Sync/InternalVersionsService.cs Updated implementation; changed filename constant to "stage-containers.txt"
eng/update-dependencies/Sync/SyncInternalReleaseCommand.cs Updated to use stage container strings throughout the sync process
eng/update-dependencies/PipelinesService.cs New service extracting Azure DevOps pipeline operations for better separation of concerns
eng/update-dependencies/PipelineArtifactProvider.cs Refactored to use new PipelinesService instead of directly accessing Azure DevOps clients
eng/update-dependencies/FromStagingPipelineOptions.cs Changed parameter from int to string; added extension method with regex validation to extract build ID
eng/update-dependencies/FromStagingPipelineCommand.cs Updated to accept stage container strings; added diagnostic logging of pipeline tags
eng/pipelines/update-dependencies-internal-unofficial.yml Updated parameter to pass stage container string instead of build ID
eng/pipelines/update-dependencies-internal-official.yml Updated parameter to pass stage container string instead of build ID
eng/pipelines/pipelines/update-dependencies-internal.yml Updated parameter definition and usage for stage container strings
Comments suppressed due to low confidence (1)

eng/update-dependencies/Sync/InternalStageContainers.cs:18

  • There is an extra space in the XML doc comment. The cref attribute should be <see cref="InternalStageContainers"/> without the space after the opening tag.

@lbussell lbussell enabled auto-merge (squash) January 23, 2026 17:38
@lbussell lbussell merged commit d6aad4b into dotnet:nightly Jan 23, 2026
124 checks passed
@lbussell lbussell deleted the update-deps-labels-2 branch January 23, 2026 17:43
@github-actions github-actions bot added the needs-backport PR that should be backported to another branch label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport PR that should be backported to another branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants