Skip to content

Rename test methods hidden by same-name overloads so they can be run #38766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rename test methods hidden by same-name overloads so they can be run #38766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
792e0b8
Initial plan
Copilot Aug 7, 2026
c56fa42
Rename generic test overloads to avoid xUnit discovery conflicts
Copilot Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/EFCore.Cosmos.FunctionalTests/ModelBuilding/CosmosModelBuilderGenericTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ public override void Primitive_collections_can_be_made_concurrency_tokens()
base.Primitive_collections_can_be_made_concurrency_tokens).Message);

public override void Properties_can_have_custom_type_value_converter_type_set()
=> Properties_can_have_custom_type_value_converter_type_set<string>();
=> Properties_can_have_custom_type_value_converter_type_set_implementation<string>();

public override void Properties_can_have_non_generic_value_converter_set()
=> Properties_can_have_non_generic_value_converter_set<string>();
=> Properties_can_have_non_generic_value_converter_set_implementation<string>();

public override void Properties_can_have_provider_type_set()
=> Properties_can_have_provider_type_set<string>();
=> Properties_can_have_provider_type_set_implementation<string>();

public override void Properties_can_be_set_to_generate_values_on_Add()
{
Expand Down Expand Up @@ -712,13 +712,13 @@ public class CosmosGenericComplexType(CosmosModelBuilderFixture fixture)
: ComplexTypeTestBase(fixture), IClassFixture<CosmosModelBuilderFixture>
{
public override void Properties_can_have_custom_type_value_converter_type_set()
=> Properties_can_have_custom_type_value_converter_type_set<string>();
=> Properties_can_have_custom_type_value_converter_type_set_implementation<string>();

public override void Properties_can_have_non_generic_value_converter_set()
=> Properties_can_have_non_generic_value_converter_set<string>();
=> Properties_can_have_non_generic_value_converter_set_implementation<string>();

public override void Properties_can_have_provider_type_set()
=> Properties_can_have_provider_type_set<string>();
=> Properties_can_have_provider_type_set_implementation<string>();

public override void Complex_properties_can_be_configured_by_type()
=> base.Complex_properties_can_be_configured_by_type();
Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.Cosmos.FunctionalTests/Query/Translations/StringTranslationsCosmosTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ public StringTranslationsCosmosTest(BasicTypesQueryCosmosFixture fixture, ITestO

#region Equals

public override async Task Equals()
public override async Task Instance_Equals()
{
await base.Equals();
await base.Instance_Equals();

AssertSql(
"""
Expand Down
12 changes: 6 additions & 6 deletions test/EFCore.Specification.Tests/ModelBuilding/ModelBuilderTest.ComplexType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,9 +509,9 @@ public virtual void Access_mode_can_be_overridden_at_entity_and_property_levels(

[Fact(Skip = "Issue #35613")]
public virtual void Properties_can_have_provider_type_set()
=> Properties_can_have_provider_type_set<byte[]>();
=> Properties_can_have_provider_type_set_implementation<byte[]>();

protected virtual void Properties_can_have_provider_type_set<TBytes>()
protected virtual void Properties_can_have_provider_type_set_implementation<TBytes>()
{
var modelBuilder = CreateModelBuilder();

Expand Down Expand Up @@ -590,9 +590,9 @@ public virtual void Properties_can_have_provider_type_set_for_type()

[Fact(Skip = "Issue #35613")]
public virtual void Properties_can_have_non_generic_value_converter_set()
=> Properties_can_have_non_generic_value_converter_set<byte[]>();
=> Properties_can_have_non_generic_value_converter_set_implementation<byte[]>();

protected virtual void Properties_can_have_non_generic_value_converter_set<TBytes>()
protected virtual void Properties_can_have_non_generic_value_converter_set_implementation<TBytes>()
{
var modelBuilder = CreateModelBuilder();

Expand Down Expand Up @@ -634,9 +634,9 @@ protected virtual void Properties_can_have_non_generic_value_converter_set<TByte

[Fact(Skip = "Issue #35613")]
public virtual void Properties_can_have_custom_type_value_converter_type_set()
=> Properties_can_have_custom_type_value_converter_type_set<byte[]>();
=> Properties_can_have_custom_type_value_converter_type_set_implementation<byte[]>();

protected virtual void Properties_can_have_custom_type_value_converter_type_set<TBytes>()
protected virtual void Properties_can_have_custom_type_value_converter_type_set_implementation<TBytes>()
{
var modelBuilder = CreateModelBuilder();

Expand Down
12 changes: 6 additions & 6 deletions test/EFCore.Specification.Tests/ModelBuilding/ModelBuilderTest.NonRelationship.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,9 +803,9 @@ public virtual void Access_mode_can_be_overridden_at_entity_and_property_levels(

[Fact]
public virtual void Properties_can_have_provider_type_set()
=> Properties_can_have_provider_type_set<byte[]>();
=> Properties_can_have_provider_type_set_implementation<byte[]>();

protected virtual void Properties_can_have_provider_type_set<TBytes>()
protected virtual void Properties_can_have_provider_type_set_implementation<TBytes>()
{
var modelBuilder = CreateModelBuilder();

Expand Down Expand Up @@ -872,9 +872,9 @@ public virtual void Properties_can_have_provider_type_set_for_type()

[Fact]
public virtual void Properties_can_have_non_generic_value_converter_set()
=> Properties_can_have_non_generic_value_converter_set<byte[]>();
=> Properties_can_have_non_generic_value_converter_set_implementation<byte[]>();

protected virtual void Properties_can_have_non_generic_value_converter_set<TBytes>()
protected virtual void Properties_can_have_non_generic_value_converter_set_implementation<TBytes>()
{
var modelBuilder = CreateModelBuilder();

Expand Down Expand Up @@ -910,9 +910,9 @@ protected virtual void Properties_can_have_non_generic_value_converter_set<TByte

[Fact]
public virtual void Properties_can_have_custom_type_value_converter_type_set()
=> Properties_can_have_custom_type_value_converter_type_set<byte[]>();
=> Properties_can_have_custom_type_value_converter_type_set_implementation<byte[]>();

protected virtual void Properties_can_have_custom_type_value_converter_type_set<TBytes>()
protected virtual void Properties_can_have_custom_type_value_converter_type_set_implementation<TBytes>()
{
var modelBuilder = CreateModelBuilder();

Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Specification.Tests/Query/Translations/StringTranslationsTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ protected virtual bool IsCaseSensitive
#region Equals

[Fact]
public virtual Task Equals()
public virtual Task Instance_Equals()
=> IsCaseSensitive
? AssertQuery(ss => ss.Set<BasicTypesEntity>().Where(b => b.String.Equals("Seattle")))
: AssertQuery(
Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.SqlServer.FunctionalTests/Query/Translations/StringTranslationsSqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ protected override bool IsCaseSensitive

#region Equals

public override async Task Equals()
public override async Task Instance_Equals()
{
await base.Equals();
await base.Instance_Equals();

AssertSql(
"""
Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.Sqlite.FunctionalTests/Query/Translations/StringTranslationsSqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ public StringTranslationsSqliteTest(BasicTypesQuerySqliteFixture fixture, ITestO

#region Equals

public override async Task Equals()
public override async Task Instance_Equals()
{
await base.Equals();
await base.Instance_Equals();

AssertSql(
"""
Expand Down
Loading