Skip to content

Add regression test: #4473, extern function parameters not flagged as unused#19580

Merged
T-Gro merged 2 commits intomainfrom
regression-test/issue4473-2b44a41f285c4ac5
Apr 14, 2026
Merged

Add regression test: #4473, extern function parameters not flagged as unused#19580
T-Gro merged 2 commits intomainfrom
regression-test/issue4473-2b44a41f285c4ac5

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

🤖 This PR was created by Repo Assist.

Fixes #4473

Adds a regression test verifying that extern function parameters are no longer incorrectly flagged as unused when --warnon:1182 is enabled.

The test compiles an extern declaration with named parameters (frequency, duration) using --warnon:1182 and verifies no FS1182 warnings are produced.

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@7c7feb61a52b662eb2089aa2945588b7a200d404

… unused

Fixes #4473

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions bot requested a review from a team as a code owner April 14, 2026 13:27
@github-actions github-actions bot added AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes labels Apr 14, 2026
@github-actions github-actions bot requested review from T-Gro and abonie April 14, 2026 13:27
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 14, 2026
@T-Gro T-Gro enabled auto-merge (squash) April 14, 2026 14:08
@github-actions
Copy link
Copy Markdown
Contributor Author

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro merged commit 6e6833a into main Apr 14, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

extern function arguments are marked as unused

1 participant