Fix AttributeUsage.AllowMultiple not inherited for C#-defined attributes#19583
Closed
Fix AttributeUsage.AllowMultiple not inherited for C#-defined attributes#19583
Conversation
…tes (#17107) The F# compiler was not walking the inheritance chain for IL-imported (C#) attribute types when checking AllowMultiple. The supersOfTyconRef function only used tcaug_super, which is not populated for IL types. This fix simplifies TryFindAttributeUsageAttribute to only check the current type, and adds a recursive allowsMultiple function in PostInferenceChecks that walks the inheritance chain using GetSuperTypeOfType, which correctly handles both F# and IL-imported types. Based on work by edgarfgp in PR #19315. Fixes #17107 Co-authored-by: edgarfgp <31915729+edgarfgp@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The F# compiler was not walking the inheritance chain for IL-imported (C#) attribute types when checking
AllowMultiple. ThesupersOfTyconReffunction only usedtcaug_super, which is not populated for IL types.This fix simplifies
TryFindAttributeUsageAttributeto only check the current type definition, and adds a recursiveallowsMultiplefunction inPostInferenceChecksthat walks the inheritance chain usingGetSuperTypeOfType, which correctly handles both F# and IL-imported types viaILTypeDef.Extends.Based on work by @edgarfgp in PR #19315. Rebased onto main after the TypedTreeOps split (#19521).
Fixes #17107
Checklist