Skip to content

Don't regenerate xlf files in source-only builds #19968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T-Gro wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Don't regenerate xlf files in source-only builds #19968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions FSharpBuild.Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
<Import Project="eng\targets\NuGet.targets" Condition="'$(DISABLE_ARCADE)' != 'true'"/>
<Import Project="FSharp.Profiles.props" />

<!-- Source-only/VMR builds must not regenerate xlf files (#19961). Arcade re-enables
UpdateXlfOnBuild for non-CI builds in its targets phase, so this must follow the Arcade import to win. -->
<PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">
<UpdateXlfOnBuild>false</UpdateXlfOnBuild>
</PropertyGroup>

<PropertyGroup>
<DefineConstants Condition="'$(Configuration)'=='release'">$(DefineConstants);Release</DefineConstants>
<DefineConstants Condition="'$(Configuration)'=='debug'">$(DefineConstants);Debug</DefineConstants>
Expand Down
Loading