[UIKit] Enable nullability and clean up UIActionSheet. #24593
Conversation
This is file 3 of 30 files with nullability disabled in UIKit. * Enable nullability. * Add nullable annotations. * Improve XML documentation. Contributes towards #17285.
There was a problem hiding this comment.
Pull request overview
This PR enables nullable reference types and inlines documentation for UIKit.UIActionSheet, aligning it with the broader nullability work in UIKit and moving docs from external XML into the source file.
Changes:
- Enabled
#nullableinUIActionSheet.csand annotated theUIActionSheetconstructors and related APIs with appropriate nullable annotations. - Replaced the external XML documentation for
UIActionSheetwith inline XML documentation comments directly on the class and its members, updating and clarifying the docs in the process. - Removed the now-unused
UIActionSheet.xmldocs file and the corresponding<include>reference fromuikit.cs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/uikit.cs |
Removed the <include> reference to the external UIActionSheet XML doc now that docs are inline on the type. |
src/UIKit/UIActionSheet.cs |
Enabled nullability, updated constructor signatures with nullable annotations, and added/modernized XML documentation for the class and its members. |
docs/api/UIKit/UIActionSheet.xml |
Removed the standalone XML documentation file superseded by inline documentation comments. |
✅ [CI Build #19273e3] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #19273e3] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #19273e3] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #19273e3] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #19273e3] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #19273e3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #19273e3] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #19273e3] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #19273e3] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 3 of 30 files with nullability disabled in UIKit.
Contributes towards #17285.