-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Bump Android minimum API level from 21 to 24 #126838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2590cd0
18fef16
58e5bf6
d150ef8
ad108f5
57db7b2
7c91e8d
46f9e5f
b095acd
188a315
491c2af
c1bab88
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,19 +27,21 @@ | |
| - eng/native/build-commons.sh | ||
| - eng/native/gen-buildsys.cmd | ||
| - src/native/libs/build-native.sh | ||
| - src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/MachObjectWriter.cs | ||
| - src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs | ||
| - src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets | ||
| - src/mono/mono/tools/offsets-tool/offsets-tool.py | ||
| - src/mono/mono/offsets/offsets-tool.py | ||
| - src/mono/msbuild/apple/build/AppleBuild.targets | ||
| - src/installer/pkg/sfx/bundle/shared-framework-distribution-template-x64.xml | ||
| - src/installer/pkg/sfx/bundle/shared-framework-distribution-template-arm64.xml | ||
| - src/mono/msbuild/common/MonoAOTCompiler.props | ||
| - src/tasks/AppleAppBuilder/Xcode.cs | ||
| - src/tasks/MobileBuildTasks/Apple/AppleProject.cs | ||
| - src/tasks/MobileBuildTasks/Android/AndroidProject.cs | ||
| - src/tasks/AndroidAppBuilder/ApkBuilder.cs | ||
| - src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets | ||
| - https://github.com/dotnet/sdk repo > src/Installer/redist-installer/targets/GeneratePKG.targets | ||
| --> | ||
| <AndroidApiLevelMin>21</AndroidApiLevelMin> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Above is a list of all the files that might be hardcoding 21, this PR is missing some.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The offsets-tool.py still has 21 |
||
| <AndroidApiLevelMin>24</AndroidApiLevelMin> | ||
|
simonrozsival marked this conversation as resolved.
|
||
| <iOSVersionMin>13.0</iOSVersionMin> | ||
|
simonrozsival marked this conversation as resolved.
|
||
| <tvOSVersionMin>13.0</tvOSVersionMin> | ||
| <macOSVersionMin>14.0</macOSVersionMin> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,7 +107,7 @@ public static void IsOSPlatformVersionAtLeast_InvalidArgs_Throws() | |
| public static void TestIsOSVersionAtLeast_Android() => TestIsOSVersionAtLeast("Android"); | ||
|
|
||
| [Fact, PlatformSpecific(TestPlatforms.Android)] | ||
| public static void TestIsOSVersionAtLeast_Android_21() => Assert.True(OperatingSystem.IsAndroidVersionAtLeast(21)); // 21 is our min supported version | ||
| public static void TestIsOSVersionAtLeast_Android_24() => Assert.True(OperatingSystem.IsAndroidVersionAtLeast(24)); // 24 is our min supported version | ||
|
Comment on lines
109
to
+110
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test should actually still pass unchanged, can you introduce a new test and keep the old one? (or use
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, we could do that, but I don't see a value of such test. If anything, we might want to completely drop this test.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we keep the version in the name of the test, instead of having something like TestIsOSVersionSupported_Android or TestIsAndroidVersionSupported? |
||
|
|
||
| [Fact, PlatformSpecific(TestPlatforms.iOS)] | ||
| public static void TestIsOSPlatform_IOS() => TestIsOSPlatform("iOS", OperatingSystem.IsIOS); | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -109,7 +109,7 @@ def require_emscipten_path (args): | |||||
| self.sys_includes=[] | ||||||
| self.target = None | ||||||
| self.target_args = [] | ||||||
| android_api_level = "-D__ANDROID_API=21" | ||||||
| android_api_level = "-D__ANDROID_API=24" | ||||||
|
||||||
| android_api_level = "-D__ANDROID_API=24" | |
| android_api_level = "-D__ANDROID_API__=24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger do you know if this is a relevant comment from Copilot or not? I suppose that if it's been this way up until now it should stay this way going forward.
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -116,14 +116,6 @@ include(${CMAKE_CURRENT_LIST_DIR}/extra_libs.cmake) | |||||||
| set(NATIVE_LIBS_EXTRA) | ||||||||
| append_extra_system_libs(NATIVE_LIBS_EXTRA) | ||||||||
|
|
||||||||
| if (CLR_CMAKE_TARGET_ANDROID AND NOT HAVE_GETIFADDRS) | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume this was android API specific, right?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All this block does is add runtime/src/native/libs/System.Native/pal_ifaddrs.h Lines 10 to 12 in cab811a
|
||||||||
| add_definitions(-DANDROID_GETIFADDRS_WORKAROUND) | ||||||||
| add_compile_options(-Wno-gnu-zero-variadic-macro-arguments) | ||||||||
|
|
||||||||
| list (APPEND NATIVE_LIBS_EXTRA -llog) | ||||||||
| list (APPEND NATIVE_SOURCES pal_ifaddrs.c) | ||||||||
| endif () | ||||||||
|
|
||||||||
| if (GEN_SHARED_LIB) | ||||||||
| add_library(System.Native | ||||||||
| SHARED | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the original path, shouldn't this be
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/MachObjectWriter.Aot.cs? (aotvsCommon)