Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3042916 - #130641
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3042916#130641dotnet-bot wants to merge 21 commits into
Conversation
… Build ID 3021431
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
… Build ID 3021437
… Build ID 3021437
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "40878e8da730f9e4ecf8990e12ba2371a90aaa10",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "ef1428e885a3a330cfcdb2246ff4e24211347283",
"last_reviewed_commit": "40878e8da730f9e4ecf8990e12ba2371a90aaa10",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "ef1428e885a3a330cfcdb2246ff4e24211347283",
"last_recorded_worker_run_id": "29690682347",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "40878e8da730f9e4ecf8990e12ba2371a90aaa10",
"review_id": 4730924490
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: This is an automated OneLocBuild check-in that imports localized strings handed back from the downstream translation pipeline for the System.Text.Json source generator. It keeps the translated .xlf resources in sync with the English source strings.
Approach: The PR adds six new trans-unit entries (three diagnostics, each with a MessageFormat and a Title) related to polymorphic derived-type validation — DerivedTypeIsNotSupported, DerivedTypeDiscriminatorCollision, and InferredDerivedTypeIsNotAccessible — to each of the 13 language .xlf files under src/libraries/System.Text.Json/gen/Resources/xlf/. Every entry preserves the identical English <source>, supplies a translated <target>, and keeps placeholder tokens ({0}, {1}) intact. The change is additive only (390 insertions, 0 deletions) with no source-code, ordering, or structural changes.
Summary: This is a low-risk, machine-generated localization update with no functional impact. The additions are consistent across all 13 locales and preserve source text and format placeholders. Note that the corresponding resource keys are not yet present in gen/Resources/Strings.resx on this branch; this is the expected lag between the loc handback and the source string addition and is harmless — unused .xlf entries are ignored until the matching resx keys land. No actionable issues found. LGTM.
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 55.8 AIC · ⌖ 14.4 AIC · ⊞ 10K
… Build ID 3027419
… Build ID 3030964
… Build ID 3030966
… Build ID 3030966
… Build ID 3032269
… Build ID 3032286
… Build ID 3032286
… Build ID 3036708
… Build ID 3038221
… Build ID 3038554
… Build ID 3038776
… Build ID 3038785
… Build ID 3038785
… Build ID 3039263
… Build ID 3040360
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.