[WIP]: Wire on-demand in-proc crash report generation into the fatal error handler API- #131414

src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj

@@ -219,6 +219,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\ExceptionIDs.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\StackFrameIterator.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\AsmOffsets.cs" />
+    <Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\ExceptionHandling.CoreCLR.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\InternalCalls.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\GCSettings.CoreCLR.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\JitInfo.CoreCLR.cs" />

src/coreclr/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionHandling.CoreCLR.cs

@@ -0,0 +1,15 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+namespace System.Runtime.ExceptionServices
+{
+    public static partial class ExceptionHandling
+    {
+        [LibraryImport(RuntimeHelpers.QCall, EntryPoint = "ExceptionHandling_TrySetFatalErrorHandler")]
+        [return: MarshalAs(UnmanagedType.U1)]
+        private static partial bool TrySetFatalErrorHandler(IntPtr handler);
+    }
+}

src/coreclr/debug/crashreport/inproccrashreporter.cpp

@@ -214,7 +214,7 @@ class ThreadEnumerationContext
         size_t methodNameScratchSize,
         uint64_t crashingTid,
         uint32_t frameLimitPerThread,
-        void* signalContext)
+        const void* signalContext)
     {
         Init(writer, consoleWriter, moduleInfoCallback, moduleTable, formatter, methodNameScratch, methodNameScratchSize, crashingTid, frameLimitPerThread, signalContext);
     }
@@ -237,7 +237,7 @@ class ThreadEnumerationContext
         size_t methodNameScratchSize,
         uint64_t crashingTid,
         uint32_t frameLimitPerThread,
-        void* signalContext)
+        const void* signalContext)
     {
         m_frameContext.jsonWriter = writer;
         m_frameContext.consoleWriter = consoleWriter;
@@ -310,7 +310,7 @@ class ThreadEnumerationContext
     void EndCurrentJsonThreadBlock();
 
     FrameContext m_frameContext;
-    void* m_signalContext;
+    const void* m_signalContext;
     size_t m_threadCount;
     uint64_t m_crashingTid;
     uint32_t m_currentThreadFrameCount;
@@ -366,7 +366,7 @@ class InProcCrashReporter
     // Signal-path report generation, invoked by the PAL fatal-signal dispatcher.
     bool CreateReport(
         int signal,
-        void* context,
+        const void* context,
         bool serialize);
 
     // On-demand report generation. Runs the same emit core as the signal path
@@ -375,7 +375,7 @@ class InProcCrashReporter
     bool CreateReport(
         InProcCrashReportOutputFormat outputFormat,
         int signal,
-        void* context,
+        const void* context,
         InProcCrashReportOutputCallback outputCallback,
         void* callbackContext);
 
@@ -393,14 +393,14 @@ class InProcCrashReporter
     InProcCrashReporter& operator=(const InProcCrashReporter&) = delete;
 
     void EmitSynthesizedCrashThread(
-        void* context,
+        const void* context,
         bool walkStack);
 
     void EmitStackOverflowCrashThread();
 
     void EmitThreads(
         InProcCrashReportCrashKind crashKind,
-        void* context);
+        const void* context);
 
     void BeginConsoleReport(int signal);
     bool EndConsoleReport();
@@ -453,20 +453,20 @@ class CrashReportHelpers
 
     static void WriteRegistersToJson(
         SignalSafeJsonWriter* writer,
-        void* context);
+        const void* context);
 
     static uint64_t GetInstructionPointer(
-        void* context);
+        const void* context);
 
     static uint64_t GetStackPointer(
-        void* context);
+        const void* context);
 
     static uint64_t GetFramePointer(
-        void* context);
+        const void* context);
 
     static void WriteCrashSiteFrameToJson(
         SignalSafeJsonWriter* writer,
-        void* context);
+        const void* context);
 
     static void BuildMethodName(
         char* buffer,
@@ -529,7 +529,7 @@ class CrashReportHelpers
     static void BeginJsonStackFrames(
         SignalSafeJsonWriter* jsonWriter,
         bool writeCrashSiteFrame,
-        void* signalContext);
+        const void* signalContext);
 
     static void EndJsonStackFrames(
         SignalSafeJsonWriter* jsonWriter);
@@ -587,7 +587,7 @@ class CrashReportHelpers
 bool
 InProcCrashReporter::CreateReport(
     int signal,
-    void* context,
+    const void* context,
     bool serialize)
 {
     if (!serialize)
@@ -664,7 +664,7 @@ bool
 InProcCrashReporter::CreateReport(
     InProcCrashReportOutputFormat outputFormat,
     int signal,
-    void* context,
+    const void* context,
     InProcCrashReportOutputCallback outputCallback,
     void* callbackContext)
 {
@@ -722,7 +722,7 @@ InProcCrashReporter::CreateReport(
 void
 InProcCrashReporter::EmitThreads(
     InProcCrashReportCrashKind crashKind,
-    void* context)
+    const void* context)
 {
     m_jsonWriter.OpenArray("threads");
     if (crashKind == InProcCrashReportCrashKind::StackOverflow)
@@ -971,7 +971,7 @@ bool
 InProcCrashReportCreateReport(
     InProcCrashReportOutputFormat outputFormat,
     int signal,
-    void* context,
+    const void* context,
     InProcCrashReportOutputCallback outputCallback,
     void* callbackContext)
 {
@@ -1170,7 +1170,7 @@ CrashReportHelpers::AppendString(
 void
 CrashReportHelpers::WriteRegistersToJson(
     SignalSafeJsonWriter* writer,
-    void* context)
+    const void* context)
 {
     uint64_t ipValue = GetInstructionPointer(context);
     uint64_t spValue = GetStackPointer(context);
@@ -1247,47 +1247,47 @@ CrashReportHelpers::WriteRegistersToJson(
 
 uint64_t
 CrashReportHelpers::GetInstructionPointer(
-    void* context)
+    const void* context)
 {
     if (context == nullptr)
     {
         return 0;
     }
 
-    ucontext_t* ucontext = reinterpret_cast<ucontext_t*>(context);
+    const ucontext_t* ucontext = reinterpret_cast<const ucontext_t*>(context);
     return CRASH_MCREG_PC(ucontext);
 }
 
 uint64_t
 CrashReportHelpers::GetStackPointer(
-    void* context)
+    const void* context)
 {
     if (context == nullptr)
     {
         return 0;
     }
 
-    ucontext_t* ucontext = reinterpret_cast<ucontext_t*>(context);
+    const ucontext_t* ucontext = reinterpret_cast<const ucontext_t*>(context);
     return CRASH_MCREG_SP(ucontext);
 }
 
 uint64_t
 CrashReportHelpers::GetFramePointer(
-    void* context)
+    const void* context)
 {
     if (context == nullptr)
     {
         return 0;
     }
 
-    ucontext_t* ucontext = reinterpret_cast<ucontext_t*>(context);
+    const ucontext_t* ucontext = reinterpret_cast<const ucontext_t*>(context);
     return CRASH_MCREG_FP(ucontext);
 }
 
 void
 CrashReportHelpers::WriteCrashSiteFrameToJson(
     SignalSafeJsonWriter* writer,
-    void* context)
+    const void* context)
 {
     uint64_t ipValue = GetInstructionPointer(context);
     uint64_t spValue = GetStackPointer(context);
@@ -1619,7 +1619,7 @@ void
 CrashReportHelpers::BeginJsonStackFrames(
     SignalSafeJsonWriter* jsonWriter,
     bool writeCrashSiteFrame,
-    void* signalContext)
+    const void* signalContext)
 {
     if (jsonWriter == nullptr)
     {
@@ -1993,7 +1993,7 @@ ThreadEnumerationContext::EnumerateThreads(
 
 void
 InProcCrashReporter::EmitSynthesizedCrashThread(
-    void* context,
+    const void* context,
     bool walkStack)
 {
     uint64_t crashingTid = static_cast<uint64_t>(minipal_get_current_thread_id());

src/coreclr/debug/crashreport/inproccrashreporter.h

@@ -114,7 +114,7 @@ void InProcCrashReportInitializeServices(const InProcCrashReporterServicesSettin
 bool InProcCrashReportCreateReport(
     InProcCrashReportOutputFormat outputFormat,
     int signal,
-    void* context,
+    const void* context,
     InProcCrashReportOutputCallback outputCallback,
     void* callbackContext);
 

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

@@ -307,7 +307,7 @@ internal static Exception GetClasslibException(ExceptionIDs id, IntPtr address)
             Exception? e = null;
             try
             {
-                e = ((delegate*<ExceptionIDs, Exception>)pGetRuntimeExceptionFunction)(id);
+                e = ((delegate*<ExceptionIDs, IntPtr, Exception>)pGetRuntimeExceptionFunction)(id, address);
             }
             catch when (true)
             {
@@ -362,7 +362,8 @@ internal static Exception GetClasslibExceptionFromEEType(ExceptionIDs id, Method
             Exception? e = null;
             try
             {
-                e = ((delegate*<ExceptionIDs, Exception>)pGetRuntimeExceptionFunction)(id);
+                // The MethodTable-based lookup path has no faulting instruction pointer to surface.
+                e = ((delegate*<ExceptionIDs, IntPtr, Exception>)pGetRuntimeExceptionFunction)(id, IntPtr.Zero);
             }
             catch when (true)
             {
@@ -424,8 +425,9 @@ public static void FailedAllocation(MethodTable* pEEType, bool fIsOverflow)
         // There are only a few cases where this happens now (the fast allocation helpers), so we limit the
         // exception types that MRT will return.
         [RuntimeExport("GetRuntimeException")]
-        public static Exception GetRuntimeException(ExceptionIDs id)
+        public static Exception GetRuntimeException(ExceptionIDs id, IntPtr faultingIP)
         {
+            _ = faultingIP;
             switch (id)
             {
                 case ExceptionIDs.OutOfMemory: