Add defensive null‑check for pTargetMD - #131994
Open
dovydenkovas wants to merge 1 commit into
Open
Conversation
Check before accessing pTargetMD prevents a potential dereference if the target method descriptor is not supplied, while preserving the existing assertion and token‑writing logic.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
community-contribution
jkotas
requested changes
Aug 7, 2026
jkotas
left a comment
jkotas
left a comment
Member
There was a problem hiding this comment.
This is not a correct fix for the theoretical problem found by your scanner.
Do you have a repro that is able to hit the problematic condition? If not, this should be closed.
jkotas
added
the
needs-author-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pCalleeMDcould be dereferenced even if it isNULLbecause there are no checks in place. Add checks inGenerateGCDescriptormethod before accessingpTargetMDto prevent a potential null pointer dereference if the target method descriptor is not supplied.Signed-off-by: Aleksandr Dovydenkov asd@altlinux.org
Found by Linux Verification Center (linuxtesting.org) with SVACE.