Skip to content

Reduce the GC handle cost of every RCW in ComWrappers #132040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sergio0694 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Reduce the GC handle cost of every RCW in ComWrappers #132040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a50b8c7
Partition the ComWrappers RCW cache into per-processor buckets
Sergio0694 Aug 8, 2026
2074c0d
Use WeakGCHandle<NativeObjectWrapper> in the RCW cache
Sergio0694 Aug 8, 2026
56f43bb
Skip the resurrection tracking handle for RCWs without a finalizer
Sergio0694 Aug 8, 2026
b6e44e6
Use WeakGCHandle<object> for the resurrection tracking handle
Sergio0694 Aug 8, 2026
610a1b6
Use WeakGCHandle<object> for the RCW proxy handle
Sergio0694 Aug 8, 2026
6ac4779
Branch directly on TryGetTarget when collecting tracked proxies
Sergio0694 Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...eclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,14 @@ internal static unsafe bool ObjectHasComponentSize(object obj)
return GetMethodTable(obj)->HasComponentSize;
}

// Returns true iff the type of the object declares a finalizer.
// Callers are required to keep obj alive
[MethodImpl(MethodImplOptions.AggressiveInlining)]

@AaronRobinsonMSFT AaronRobinsonMSFT Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove AggressiveInlining unless it is deemed necessary.

internal static unsafe bool ObjectHasFinalizer(object obj)
{
return GetMethodTable(obj)->HasFinalizer;
}

/// <summary>
/// Boxes a given value using an input <see cref="MethodTable"/> to determine its type.
/// </summary>
Expand Down
8 changes: 8 additions & 0 deletions ...ot/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.NativeAot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,14 @@ internal static unsafe bool ObjectHasComponentSize(object obj)
return GetMethodTable(obj)->HasComponentSize;
}

// Returns true iff the type of the object declares a finalizer.
// Callers are required to keep obj alive
[MethodImpl(MethodImplOptions.AggressiveInlining)]

@AaronRobinsonMSFT AaronRobinsonMSFT Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove AggressiveInlining unless it is deemed necessary.

internal static unsafe bool ObjectHasFinalizer(object obj)
{
return GetMethodTable(obj)->IsFinalizable;
}

public static void PrepareMethod(RuntimeMethodHandle method)
{
if (method.Value == IntPtr.Zero)
Expand Down
9 changes: 5 additions & 4 deletions ...stem.Private.CoreLib/src/System/Runtime/InteropServices/TrackerObjectManager.NativeAot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ internal static void DetachNonPromotedObjects()
ReferenceTrackerNativeObjectWrapper? nativeObjectWrapper = Unsafe.As<ReferenceTrackerNativeObjectWrapper>(weakNativeObjectWrapperHandle.Target);
if (nativeObjectWrapper != null &&
nativeObjectWrapper.TrackerObject != IntPtr.Zero &&
!RuntimeImports.RhIsPromoted(nativeObjectWrapper.ProxyHandle.Target))
nativeObjectWrapper.ProxyHandle.TryGetTarget(out object? proxyTarget) &&
!RuntimeImports.RhIsPromoted(proxyTarget))
{
// Notify the wrapper it was not promoted and is being collected.
BeforeWrapperFinalized(nativeObjectWrapper.TrackerObject);
Expand All @@ -205,9 +206,9 @@ internal static unsafe class FindReferenceTargetsCallback
internal ref struct Instance
{
private readonly IntPtr _vtable; // First field is IUnknown based vtable.
public GCHandle RootObject;
public WeakGCHandle<object> RootObject;

public Instance(GCHandle handle)
public Instance(WeakGCHandle<object> handle)
{
_vtable = (IntPtr)Unsafe.AsPointer(in FindReferenceTargetsCallback.Vftbl);
RootObject = handle;
Expand Down Expand Up @@ -240,7 +241,7 @@ private static unsafe int IFindReferenceTargetsCallback_FoundTrackerTarget(IntPt
return HResults.E_POINTER;
}

object sourceObject = ((FindReferenceTargetsCallback.Instance*)pThis)->RootObject.Target!;
_ = ((FindReferenceTargetsCallback.Instance*)pThis)->RootObject.TryGetTarget(out object? sourceObject);

if (!TryGetObject(referenceTrackerTarget, out object? targetObject))
{
Expand Down
Loading
Loading