[cDAC] Disable Helix job monitor on XPlat dump generation - #132043
Merged
Conversation
rcj1
added
the
NO-MERGE
Contributor
Author
|
/azp run runtime-diagnostics |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the runtime-diagnostics Azure Pipelines definition to change the default mode for cDAC dump testing and to adjust the Helix submission parameters for the x-plat dump generation leg.
Changes:
- Change the default
cdacDumpTestModeparameter fromsingle-legtoxplat. - Add
/p:EnableHelixJobMonitor=falseto the Helix submission used for x-plat dump generation.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtime-diagnostics.yml | Changes cDAC dump test mode default and modifies Helix send parameters for dump generation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
eng/pipelines/runtime-diagnostics.yml:64
- Changing cdacDumpTestMode default to
xplatwill cause PR-triggered runs of this pipeline to execute the cross-platform dump generation + fan-in dump test legs by default (see theif ... cdacDumpTestMode == 'xplat'conditions later in the file). That substantially increases CI time/cost and can raise reliability risks (large dump artifacts / fan-in dependencies) for routine PR validation; nightly Schedule already forces xplat regardless of this parameter.
default: xplat
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
This was referenced Aug 8, 2026
rcj1
changed the title
rcj1
added
area-Diagnostics-cdac
and removed
NO-MERGE
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
rcj1
marked this pull request as ready for review
August 9, 2026 01:45
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
steveisok
approved these changes
Aug 9, 2026
Contributor
Author
|
/ba-g unrelated sos dump failure |
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the Helix Job Monitor for cDAC cross-platform dump generation.
This restores the previous synchronous behavior where the submitting job:
dumps.tar.gzintoartifacts/helixresults.Root cause
After #129690 enabled the Helix Job Monitor globally,
SendHelixJobbegan returning immediately after submission. The cDAC dump-generation flow requiresDownloadFilesFromResults, but the monitor does not download those artifacts for the submitting job.Consequently,
Publish Dump Artifactsruns beforeartifacts/helixresultsexists, although the Helix work items later complete successfully.Fixes #131979
Note
This content was created with assistance from AI.