[api-diff] Prevent blank lines between new attributes + unchanged member#53848
Open
jeffhandley wants to merge 1 commit intodotnet:mainfrom
Open
[api-diff] Prevent blank lines between new attributes + unchanged member#53848jeffhandley wants to merge 1 commit intodotnet:mainfrom
jeffhandley wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ApiDiff’s markdown diff output formatting for the case where only attributes change on an otherwise unchanged API member, ensuring no extra blank/whitespace-only lines are emitted between the attribute diff and the unchanged member signature.
Changes:
- Skip whitespace-only lines when emitting “unchanged” member text under modified attributes (to avoid visual gaps).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was found during the review of dotnet/core#10351. Worked around it by removing the blank lines in dotnet/core@41ec2c1.
The scenario is when attributes are being added to otherwise unchanged API members.