Skip to content

Migrate ComputeCssScope to IMultiThreadableTask#54744

Open
OvesN wants to merge 2 commits into
mainfrom
dev/veronikao/migrate-ComputeCssScope-to-mt
Open

Migrate ComputeCssScope to IMultiThreadableTask#54744
OvesN wants to merge 2 commits into
mainfrom
dev/veronikao/migrate-ComputeCssScope-to-mt

Conversation

@OvesN

@OvesN OvesN commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Fixes dotnet/msbuild#14052
Migrate ComputeCssScope to IMultiThreadableTask

Copilot AI review requested due to automatic review settings June 12, 2026 14:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Static Web Assets scoped CSS build task metadata to indicate it can run as a multi-threadable MSBuild task.

Changes:

  • Mark ComputeCssScope with [MSBuildMultiThreadableTask].
Comments suppressed due to low confidence (1)

src/StaticWebAssetsSdk/Tasks/ScopedCss/ComputeCssScope.cs:24

  • The PR title/description says this task was migrated to IMultiThreadableTask, but the change only adds [MSBuildMultiThreadableTask] and the task still doesn’t implement IMultiThreadableTask (unlike other multi-threadable tasks in this repo, e.g. StaticWebAssetsGeneratePackagePropsFile). Either update the PR metadata to match, or implement IMultiThreadableTask here (including the required TaskEnvironment property).
[MSBuildMultiThreadableTask]
public class ComputeCssScope : Task
{
    [Required]
    public ITaskItem[] ScopedCssInput { get; set; }

    [Required]
    public string TargetName { get; set; }

    [Output]
    public ITaskItem[] ScopedCss { get; set; }

@OvesN OvesN enabled auto-merge (squash) June 12, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Multithreaded] Migrate ComputeCssScope in SDK

4 participants