Migrate ComputeCssScope to IMultiThreadableTask#54744
Open
OvesN wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Static Web Assets scoped CSS build task metadata to indicate it can run as a multi-threadable MSBuild task.
Changes:
- Mark
ComputeCssScopewith[MSBuildMultiThreadableTask].
Comments suppressed due to low confidence (1)
src/StaticWebAssetsSdk/Tasks/ScopedCss/ComputeCssScope.cs:24
- The PR title/description says this task was migrated to
IMultiThreadableTask, but the change only adds[MSBuildMultiThreadableTask]and the task still doesn’t implementIMultiThreadableTask(unlike other multi-threadable tasks in this repo, e.g.StaticWebAssetsGeneratePackagePropsFile). Either update the PR metadata to match, or implementIMultiThreadableTaskhere (including the requiredTaskEnvironmentproperty).
[MSBuildMultiThreadableTask]
public class ComputeCssScope : Task
{
[Required]
public ITaskItem[] ScopedCssInput { get; set; }
[Required]
public string TargetName { get; set; }
[Output]
public ITaskItem[] ScopedCss { get; set; }
JanProvaznik
approved these changes
Jun 12, 2026
AR-May
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/msbuild#14052
Migrate ComputeCssScope to IMultiThreadableTask