don't let dotnetup failure count as a install script failure #54756
Draft
nagilson wants to merge 1 commit into
Draft
don't let dotnetup failure count as a install script failure #54756nagilson wants to merge 1 commit into
dotnetup failure count as a install script failure #54756nagilson wants to merge 1 commit into
Conversation
… not just exit code but folder existence on disk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exhibited CI issue in #54752.
The
exitcodeset bydotnetupoverrides whether thecithinks the install script succeeded or not, when it did succeed here, but the CI thought it failed. We also now validate the folder rather than assumingexit code 0 = a happy path(I sound like claude in that sentence which is sad.)