Add eval coverage for dotnet-test/dotnet-test-frameworks#820
Conversation
Add a deterministic output_matches assertion for Assert.AreEqual in the MSTest try/catch refactor scenario, covering the previously-uncovered MSTest assertion CodePattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skill Coverage Report
|
There was a problem hiding this comment.
Pull request overview
This PR updates the dotnet-test plugin’s evaluation suite to increase coverage for MSTest’s Assert.AreEqual usage within the dotnet-test-frameworks skill, specifically in the scenario that refactors try/catch exception assertions to framework-native patterns.
Changes:
- Added an
output_matchesassertion intended to detect MSTestAssert.AreEqualoutput in the “Replace try-catch with framework-native exception assertions” scenario.
Show a summary per file
| File | Description |
|---|---|
| tests/dotnet-test/dotnet-test-frameworks/eval.yaml | Adds an additional output_matches assertion to increase eval coverage for MSTest Assert.AreEqual. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Address review feedback: the output_matches pattern now requires the exception message comparison (Assert.AreEqual(..., ex.Message)) rather than matching Assert.AreEqual anywhere. The CodePattern remains covered via the rubric evidence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/evaluate |
|
❌ Evaluation failed. View workflow run |
|
👋 @Evangelink — this PR has 1 unresolved review thread(s). When you're ready, please address the feedback and push an update; the triage bot will pick up the next state automatically. (Add the |
|
/evaluate |
Skill Validation Results
[1] (Plugin) Quality unchanged but weighted score is -2.4% due to: tokens (12833 → 17381), time (9.6s → 12.0s) Model: claude-opus-4.6 | Judge: claude-opus-4.6 🔍 Full Results - additional metrics and failure investigation steps
▶ Sessions Visualisation -- interactive replay of all evaluation sessions |
Summary
Adds eval-test coverage for the previously-uncovered MSTest assertion CodePattern
Assert.AreEqualin thedotnet-test/dotnet-test-frameworksskill.Change
In the "Replace try-catch with framework-native exception assertions" scenario, the MSTest refactor genuinely preserves the message check
Assert.AreEqual("...", ex.Message);. Added a deterministicoutput_matchesassertion with patternAssert\.AreEqualwhere that output is naturally expected.Verification
Measure-SkillCoverage.ps1 -PluginName dotnet-test -SkillName dotnet-test-frameworks: coverage is now 5/5 (100%),uncovered: []—Assert.AreEqualis covered, no other point regressed.SkillValidator check --plugin ./plugins/dotnet-test: ✅ all checks passed (only pre-existing, unrelated warnings).Only
tests/dotnet-test/dotnet-test-frameworks/eval.yamlwas modified.