Fix scroll bug#345
Open
cameronblandford wants to merge 3 commits into
Open
Conversation
Previously, if you were scrolled down the clue list view, anyone clicking anywhere on the clue list view would jump your scroll location back to your selected clue. This refactor fixes that problem, while converting the component into modern react syntax.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
cc @stevenhao |
Contributor
Author
|
cc @stevenhao again, what do you think? |
Member
|
taking a look! |
stevenhao
reviewed
Oct 8, 2025
| ssl: { | ||
| rejectUnauthorized: false, | ||
| } | ||
| ...(process.env.NODE_ENV === 'production' && { |
Member
There was a problem hiding this comment.
this looks safe, but what was the reason it was necessary again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Expected behavior:
Observed behavior:
I tried writing this a bunch of different ways as a class component, none of them worked. So I ended up opting for a standard functional component. As a result, the diff is bigger than I'd like. I haven't tested it with vim mode, but everything else functions as expected.
Note that the refactor into a functional component was 90% Claude's doing, I tested a bunch after but am operating partially blind.