Enable asking for confirmation on SSH signature request#335
Open
deade1e wants to merge 1 commit into
Open
Conversation
Add the capability to ask for confirmation on each SSH signature request. This is done by adding a pinentry::confirm function, a `confirm_ssh` option that defaults to None and a condition under the `sign` method in SshAgent's implementation of the ssh_agent_lib Session trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the capability to ask for confirmation on each SSH signature request. This is done by adding a pinentry::confirm function, a
confirm_sshoption that defaults to None and a condition under thesignmethod in SshAgent's implementation of the ssh_agent_lib Session trait