Fix scrollback offset bugs#11
Closed
rezigned wants to merge 1 commit into
Closed
Conversation
This was referenced Mar 1, 2024
chris-olszewski
added a commit
to vercel/turborepo
that referenced
this pull request
Mar 6, 2024
### Description Due to our use case we need to extend `vt100` with some functionality. The functionality can be added upstream, but based on the age of PRs on the project, we cannot wait for this to happen. Reviewing instructions: I quick documented changes I made from the straight `vt100` crate. Significant behavior/bug fixes will be added in future PRs General plans of changes: - Cherry pick [underflow fix](doy/vt100-rust#11) - [Support dimmed formatting](doy/vt100-rust#9) - Add a version of `Screen` that displays *all* content including lines that are now in the scrollback - Some [perf fixes](doy/vt100-rust#14) ### Testing Instructions Verified existing test suite passes on my machine. Verify test suite passes on CI
chris-olszewski
added a commit
to vercel/turborepo
that referenced
this pull request
Mar 26, 2024
### Description Port of doy/vt100-rust#11 Should address part of #7843 ### Testing Instructions Unit tests, did quick spot check that this scrolling still works. Closes TURBO-2700
Contributor
Author
|
Hi @doy, is there any chances that we can get this merged? Thank you. |
This was referenced Oct 2, 2024
Owner
|
merged, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scrollback length is larger than visible rows. There're 2 issues that I've found.
Example config
1. Extra rows returned
The
.skipmethod will skip the first 4 (10 - 6 = 4) rows, thus it'll return 6 rows in total.Even though we only want 3.
This is fixed by setting the upper bound via
.take(rows_len).2. Subtraction overflow
The
.chainmethod will take additional rows viarows_len - offseti.e. 3 - 6 = overflow! We just need 0 rows.This is fixed by using saturation.
Fix #4 #5