FEATURE Several attempts to run Crowdin CLI#16
Open
dshiryaev-plesk wants to merge 1 commit intodragosv:masterfrom
Open
FEATURE Several attempts to run Crowdin CLI#16dshiryaev-plesk wants to merge 1 commit intodragosv:masterfrom
dshiryaev-plesk wants to merge 1 commit intodragosv:masterfrom
Conversation
Owner
|
@dshiryaev-plesk I would prefer to rename backoff to retry (so backoff_max_attempts will be retry_max_attempts). As well there are no new tests for the new functionality, while the existing ones are failing. Plus I would like the defaults for the new values to be retry_max_attempts to be 1. As well a better name should be used for backoff_exp_base (It is not clear what it represents) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for your work!
Crowdin has moved their CLI in version v3 to Crowdin API v2. Crowdin API v2 works unstable, so does Crowdin CLI v3. These changes adds an ability to recall Crowdin CLI several times with an exponential backoff in case Crowdin CLI fails. The default values for the backoff:
Example for .serge config:
Can, you consider these changes to merge, please ?