Add overloaded signing util methods#649
Open
josephtaylor wants to merge 2 commits intodrallgood:mainfrom
Open
Conversation
New IPKSigningUtil methods and implementation in both PKFileBasedSigningUtil and PKInMemorySigningUtil that allow callers to provide an OutputStream that the signed pass will be written to. This allows callers to stream the output wherever they want without holding the entire signed pass in memory as a byte array.
|
|
Owner
|
ooh.. I like that idea. Thanks @josephtaylor |
drallgood
approved these changes
Oct 12, 2025
Owner
|
@josephtaylor could you please pull in main again? I fixed the certificate error so tests should pass now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New IPKSigningUtil methods and implementation in both PKFileBasedSigningUtil
and PKInMemorySigningUtil that allow callers to provide an OutputStream that
the signed pass will be written to.
This allows callers to stream the output wherever they want without
holding the entire signed pass in memory as a byte array.