Merge legend and poly.line bugfixes into master#43
Open
djvill wants to merge 7 commits intodrammock:masterfrom
Open
Merge legend and poly.line bugfixes into master#43djvill wants to merge 7 commits intodrammock:masterfrom
djvill wants to merge 7 commits intodrammock:masterfrom
Conversation
Previously, when definining both vowel and group, the wrong colors showed up in the legend if var.col.by was the same as group (the right colors showed up if var.col.by was the same as vowel). Fixed bug by changing definition of byd, such that if var.col.by==group, byd has length(unique(group)) rows and length(unique(vowel)) columns.
Fixed a bug with poly.line whereby all lines would be the same linetype if var.col.by had the same value as group. The issue had to do with the code setting poly.line.sty based on the value of var.sty.by regardless of the grouping variable. Introduced a bug in the legend where linetypes display on the wrong lines when var.sty.by!=NULL.
Fixed bug introduced in previous commit; legend correctly shows correct poly.line linetypes for groups when var.sty.by==vowel and var.col.by==group.
Fixed a bug in the legend whereby colored boxes for vowels didn't show up in the legend if plotting poly.lines with var.col.by==vowel and var.sty.by==group.
add script to test legend generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the following bugs with legend and poly.line: