Skip to content

feat: add LAPS reader permission verification to validation checks #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
l50 merged 1 commit into from
Apr 20, 2026
Merged

feat: add LAPS reader permission verification to validation checks #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions cli/internal/validate/checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,35 @@ func (v *Validator) checkLAPS(ctx context.Context, w io.Writer) {
v.addResult(w, "FAIL", "LAPS", fmt.Sprintf("LAPS password NOT set for %s", hostname), "")
}
}

// Verify LAPS reader permissions — ensure configured accounts/groups
// can actually read the ms-Mcs-AdmPwd attribute on computer objects.
readerFacts := v.lab.DomainsWithLAPSReaders()
for _, lf := range readerFacts {
dc := strings.ToUpper(lf.DCRole)
if !v.hasHost(dc) {
continue
}
for _, reader := range lf.Readers {
output := v.runPS(ctx, dc, fmt.Sprintf(
`$computers = Get-ADComputer -Filter {ms-Mcs-AdmPwd -like '*'} -Properties ms-Mcs-AdmPwd -SearchBase (Get-ADDomain).DistinguishedName -ErrorAction SilentlyContinue; `+
`Import-Module ActiveDirectory; Set-Location AD:; `+
`$found = $false; foreach ($c in $computers) { `+
`$acl = Get-Acl -Path $c.DistinguishedName; `+
`$match = $acl.Access | Where-Object { $_.IdentityReference -like '*%s*' }; `+
`if ($match) { $found = $true; break } }; `+
`if ($found) { Write-Output 'READER_OK' } else { Write-Output 'READER_NOT_FOUND' }`,
reader))
switch {
case strings.Contains(output, "READER_OK"):
v.addResult(w, "PASS", "LAPS", fmt.Sprintf("%s has LAPS read permission in %s", reader, lf.Domain), "")
case strings.Contains(output, "READER_NOT_FOUND"):
v.addResult(w, "FAIL", "LAPS", fmt.Sprintf("%s does NOT have LAPS read permission in %s", reader, lf.Domain), "")
default:
v.addResult(w, "WARN", "LAPS", fmt.Sprintf("Could not verify LAPS reader %s in %s", reader, lf.Domain), "")
}
}
}
}

func (v *Validator) checkSIDFiltering(ctx context.Context, w io.Writer) {
Expand Down
Loading