fix: correctly credit ticket-granting exploits without parser discoveries#282
Merged
Merged
Conversation
**Added:** - Added `is_ticket_grant_vuln` function to identify primitives where Kerberos ticket saves indicate success - Added `result_has_ccache_evidence` function to detect saved ticket evidence in tool output - Introduced tests for both new functions to verify correct detection logic **Changed:** - Updated exploit success detection logic to allow ticket-only primitives (e.g., delegation, RBCD, S4U) to be marked successful based on saved ticket evidence, not just parser discoveries
…dreadgoad-delegation-fixes # Conflicts: # ares-cli/src/orchestrator/result_processing/tests.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/more-attack-cov #282 +/- ##
=======================================================
Coverage ? 76.32%
=======================================================
Files ? 432
Lines ? 112992
Branches ? 0
=======================================================
Hits ? 86238
Misses ? 26754
Partials ? 0
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
is_ticket_grant_vulnandresult_has_ccache_evidencefunctions to identify when a ticket save (rather than a parser-discovered credential) should mark an exploit as successfulChanged:
process_completed_taskto treat a successful Kerberos ticket save (for relevant primitives) as sufficient evidence for marking a vulnerability as exploited, even when no parser evidence is foundRemoved: