Skip to content

refactor: switch ec2 deploy logic from BCP_BUCKET to S3_BUCKET#317

Merged
l50 merged 1 commit into
mainfrom
fix/s3
May 14, 2026
Merged

refactor: switch ec2 deploy logic from BCP_BUCKET to S3_BUCKET#317
l50 merged 1 commit into
mainfrom
fix/s3

Conversation

@l50
Copy link
Copy Markdown
Contributor

@l50 l50 commented May 14, 2026

Key Changes:

  • Replaced all usage of BCP_BUCKET with S3_BUCKET for staging and deployment
  • Simplified S3 bucket configuration by removing auto-detection from bcp config
  • Updated precondition and error messages to reference S3_BUCKET instead of BCP_BUCKET

Changed:

  • S3 bucket configuration now uses S3_BUCKET as a required variable, eliminating the previous BCP_BUCKET auto-detection logic and related shell scripting
  • All S3 upload and download commands updated to use S3_BUCKET instead of BCP_BUCKET throughout the EC2 Taskfile deployment and config tasks
  • Preconditions and error messages revised to refer to S3_BUCKET, providing clearer guidance on how to set the required variable

**Changed:**

- Replaced all usage and detection of `BCP_BUCKET` with `S3_BUCKET` for S3 staging, requiring explicit `S3_BUCKET` value via variable or environment variable
- Updated documentation and error messages to reference `S3_BUCKET` instead of `BCP_BUCKET`
- Removed shell logic for auto-detecting bucket from bcp config, simplifying configuration requirements
- Adjusted all relevant S3 upload and SSM command invocations to use `S3_BUCKET` consistently in deployment and configuration steps
@l50 l50 merged commit a05b8ab into main May 14, 2026
6 checks passed
@l50 l50 deleted the fix/s3 branch May 14, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant