hotfix: Live run/task errors#108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This hotfix addresses error handling by refactoring RuntimeError exceptions to graceful warning-based failures when SDK functions are called outside of tasks/runs, improving the user experience by preventing unexpected crashes.
Key changes:
- Replaced
RuntimeErrorexceptions with warning messages for SDK functions called outside proper context - Added early returns to prevent execution when context is missing
- Updated version from 1.11.0 to 1.11.1
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Version bump to 1.11.1 for hotfix release |
| dreadnode/tracing/span.py | Removed RuntimeError for task spans without runs, added conditional logic |
| dreadnode/main.py | Replaced RuntimeError with warnings for all SDK functions called outside context |
| docs/sdk/main.mdx | Updated documentation to reflect the new warning-based error handling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live run/task errors
Key Changes:
RuntimeErrors were being thrown when calls were made outside of tasks/runs and migrated them to warnings that gracefully failGenerated Summary:
RuntimeErrorwithwarn_at_user_stacklevel, improving user feedback when methods are called outside of a valid run context.link_objectslog_artifactlog_inputlog_metriclog_metricslog_outputlog_paramspush_updatetag1.11.0to1.11.1inpyproject.tomlreflecting these changes.This summary was generated with ❤️ by rigging