Skip to content

feat: better version and container handling#184

Merged
briangreunke merged 2 commits into
mainfrom
brian/eng-3057-fix-sync-container-names-or-ids-betwen-the-api-and-sdk-for
Sep 17, 2025
Merged

feat: better version and container handling#184
briangreunke merged 2 commits into
mainfrom
brian/eng-3057-fix-sync-container-names-or-ids-betwen-the-api-and-sdk-for

Conversation

@briangreunke
Copy link
Copy Markdown
Contributor

@briangreunke briangreunke commented Sep 17, 2025

Better container handling for local Platform

Key Changes:

  • uses container names to check available and required containers before login attempts
  • better checking of running
  • uses version tags vs sha hashes in env vars
  • renamed some of the env var files and service names (specific to Dreadnode)

Generated Summary:

  • Updated the PlatformService literal to use "dreadnode-api" and "dreadnode-ui" instead of "api" and "ui".
  • Introduced new functions in docker_.py:
    • _build_docker_compose_base_command: Constructs the base Docker Compose command from the selected version.
    • get_required_service_names: Retrieves required service names from the Docker Compose file.
  • Enhanced the equality check (__eq__) in the DockerImage class to compare digests and tags conditionally.
  • Removed redundant checks for Docker and Docker Compose installations, refactoring them into newly defined functions.
  • Revised the get_available_local_images method to skip the header line when parsing Docker images.
  • Cleaned up the platform_is_running function to use the newly added get_required_service_names for service checks.
  • These changes aim to improve service management and overall code clarity in Docker handling within the project.

This summary was generated with ❤️ by rigging

@briangreunke briangreunke marked this pull request as ready for review September 17, 2025 20:42
@briangreunke briangreunke merged commit e30a687 into main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant