feat: checks for profiles and env vars for conditional services#185
Merged
briangreunke merged 1 commit intoSep 19, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional DB/Clickhouse in Platform
If a self-hosted platform user is connecting to a remote database, we don't need to provide containers for the same service. By using "profiles" in the Docker Compose file, we can conditionally start the containers. Additionally, we can use a custom attribute in the compose file
x-override.to see if the profile should be included.Key Changes:
platform startbuilds aprofilelist based on compose envAdded:
x-overrideattrs.Generated Summary:
DockerErrorexception to provide more specific error handling for Docker-related errors._get_profiles_to_enablethat determines which Docker profiles should be enabled based on the presence of environment variables._build_docker_compose_base_commandfunction to include profiles in the command for Docker Compose._run_docker_compose_commandto raiseDockerErrorwith relevant messages, improving debugging capability.get_available_local_imagesto process output without skipping the header line, which may be necessary for correct parsing.start_platformto catchDockerError, providing feedback and attempting to stop partially started containers if the platform fails to start.This summary was generated with ❤️ by rigging