fix: ensure correct OTLP endpoint usage and fix output linking logic#221
Closed
l50 wants to merge 3 commits into
Closed
fix: ensure correct OTLP endpoint usage and fix output linking logic#221l50 wants to merge 3 commits into
l50 wants to merge 3 commits into
Conversation
l50
requested review from
briangreunke and
monoxgas
and removed request for
briangreunke
dreadnode-renovate-bot
Bot
added
the
area/tests
**Changed:** - Updated CustomOTLPSpanExporter to accept a custom_endpoint parameter, allowing use of endpoints that do not follow the OTLP default /v1/traces path - Modified Dreadnode class to pass a base endpoint and a custom_endpoint to the OTLP exporter, ensuring traces are sent to the intended API path - Fixed output linking in Task to only link output and input object hashes when output is actually logged, preventing potential NoneType errors and incorrect associations
l50
force-pushed
the
jayson/eng-3520-backend-apioteltraces-endpoint-returning-500-errors-on-trace
branch
from
8c1cfb1 to
a4c07be
Compare
…version **Changed:** - Standardized variable naming in user agent combination tests to use snake_case, improving code style and consistency in `test_otel_exporter.py` - Updated `dreadnode` package version to 1.15.4 in `uv.lock` - Decremented `uv.lock` revision number from 3 to 2 for lockfile consistency - Minor whitespace and import ordering improvements in `test_otel_exporter.py`
…nt-returning-500-errors-on-trace
Contributor
Author
|
False positive resulting from doing a pip install of sdk rather than using latest sdk code from main branch. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
linking to ensure correct behavior and prevent regression -
tests/test_otel_exporter.pyChanged:
custom_endpointparameter to allowdirect specification of the full trace endpoint, bypassing the default
/v1/tracessuffix logicand custom endpoint, ensuring traces are sent to the correct API path
hashes when the output is actually logged, preventing potential NoneType
errors and incorrect associations
Generated Summary:
CustomOTLPSpanExporterto allow bypassing OTLP's default/v1/tracesURL suffix.UnboundLocalErrorin theTaskclass by initially settingoutput_object_hashtoNonebefore condition checks.CustomOTLPSpanExporter, ensuring correct endpoint handling and User-Agent combination logic.Taskclass, ensuring proper functionality with multiple input hashes and conditional linking.This summary was generated with ❤️ by rigging