Skip to content

fix: switched API client routes to full routes#42

Merged
monoxgas merged 1 commit into
mainfrom
brian/eng-1848-fix-sdk-uses-summary-routes-vs-full-routes-for-some-traces
May 12, 2025
Merged

fix: switched API client routes to full routes#42
monoxgas merged 1 commit into
mainfrom
brian/eng-1848-fix-sdk-uses-summary-routes-vs-full-routes-for-some-traces

Conversation

@briangreunke
Copy link
Copy Markdown
Contributor

@briangreunke briangreunke commented May 6, 2025

  • summary routes were missing some required attributes
  • routes are intended and include additional details

Task and Trace Full Response Routes

Key Changes:

  • API Client now pulls task and track full responses

Changed:

  • get_run_tasks gets from the /tasks/full route
  • get_run_trace gets from the '/spans/full` route

Generated Summary:

  • Updated API endpoints in ApiClient for fetching run tasks and traces.
  • Changed the GET request URL for tasks from /tasks to /tasks/full, which might return more detailed task information.
  • Changed the GET request URL for spans from /spans to /spans/full, likely providing additional context for trace spans.
  • These modifications should improve the detail and usability of the data returned by the API related to run tasks and spans.

This summary was generated with ❤️ by rigging

- summary routes were missing some required attributes
-  routes are intended and include additional details
@briangreunke briangreunke requested a review from monoxgas May 6, 2025 01:42
@monoxgas monoxgas merged commit 878e686 into main May 12, 2025
9 checks passed
@monoxgas monoxgas deleted the brian/eng-1848-fix-sdk-uses-summary-routes-vs-full-routes-for-some-traces branch June 17, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants