Skip to content

fix: changed run id type to ULID | str to accomodate old data types#85

Merged
briangreunke merged 1 commit into
mainfrom
brian/eng-2255-bug-strikes-sdk-expects-a-ulid-for-run-ids
Jun 19, 2025
Merged

fix: changed run id type to ULID | str to accomodate old data types#85
briangreunke merged 1 commit into
mainfrom
brian/eng-2255-bug-strikes-sdk-expects-a-ulid-for-run-ids

Conversation

@briangreunke
Copy link
Copy Markdown
Contributor

@briangreunke briangreunke commented Jun 18, 2025

Allow string type for RunSummary.id field

Summary

Updates the RunSummary.id field type annotation to accept both ULID and str types.

Changes

  • Modified RunSummary.id type from ULID to ULID | str in the RunSummary model

Rationale

This change provides more flexibility for the id field, allowing it to accept string representations in addition to proper ULID objects. This is useful for scenarios where:

  • IDs are received as strings from external APIs or serialized data
  • Backward compatibility is needed with existing string-based ID implementations

Generated Summary:

  • Updated the id field in the RunSummary model to support both ULID and str types.
  • This change enhances flexibility in handling different identifier formats for runs.
  • The data model now allows for backward compatibility and potential integration with other services that may use string identifiers.

This summary was generated with ❤️ by rigging

@briangreunke briangreunke merged commit 8872f4a into main Jun 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant