fix: handle null metric values from platform API changes#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: SDK failing with Pydantic validation errors after platform API hotfix for NaN handling in metrics.
Root Cause:
floatbut receivesNonefor undefined metricsSolution:
Metric.valuetype fromfloattofloat | NoneTesting:
✅ Verified SDK can parse responses with null metric values
✅ Existing functionality preserved for valid float values
✅ Authentication and project listing work correctly
Related: Platform API hotfix #1920 - NaN JSON serialization fix
Compatible with platform API changes that convert NaN evaluation metrics to null.
Generated Summary:
valuein theMetricclass fromfloattofloat | None.valueto also beNone, providing greater flexibility in representing metrics without a defined value.This summary was generated with ❤️ by rigging